Repository navigation
fix(ci): pass release-notes vars via env, not ${{ }} shell interpolation - #165
Conversation
The Release workflow inlined `LOG="${{ steps.changelog.outputs.log }}"` (and the
dispatch `notes` input) directly into the script body, so commit messages
containing double quotes broke out of the shell string — e.g. a commit titled
... "Components & serials used" ... made bash run `serials` as a command and the
whole release failed with exit 127 ("serials: command not found"), so no ZIP was
attached. Pass VERSION/CUSTOM/LOG through `env:` instead; bash reads the values
verbatim without re-parsing quotes/backticks.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe "Build release notes" workflow step moves ChangesRelease Workflow Env Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Release workflow inlined
LOG="${{ steps.changelog.outputs.log }}"(and the dispatchnotesinput) directly into the script body, so commit messages containing double quotes broke out of the shell string — e.g. a commit titled ... "Components & serials used" ... made bash runserialsas a command and the whole release failed with exit 127 ("serials: command not found"), so no ZIP was attached. Pass VERSION/CUSTOM/LOG throughenv:instead; bash reads the values verbatim without re-parsing quotes/backticks.Summary
Type of change
Related issue
Closes #
Testing
php artisan testpassesChecklist
.envsecrets committed$fillableupdated if new model columns addedcomposer auditcleanSummary by CodeRabbit