docs(changelog): record the two module changes that shipped without an entry - #329
Merged
Merged
Conversation
…n entry Two commits on develop changed how modules behave and left no trace in the changelog, which is where anyone upgrading looks first: d200222 — a module installed after the fact now has a working frontend. Its pages used to render the missing-page card while its routes answered normally, because the bundle is built before the module exists and the production image deletes node_modules right after. 1a339fb — a failing module no longer takes the whole application down. An exception in a provider's boot() escaped the try/catch around registration and took every route with it, including the screen needed to disable the module. Also folds the Unreleased section back into one Added, one Fixed and one Changed. Each merged branch appended its own heading, so the section had nine and the same kind of change appeared in three places. Changelog only — no version bump, no code.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Mes-Open/OpenMes/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog only. No version bump, no code.
Two changes shipped without an entry
Both change how modules behave, and the changelog is where anyone upgrading looks first.
d2002220— a module installed after the fact now has a working frontend. Its pages used to render the missing-page card while its routes answered normally, because the bundle is compiled before the module exists and the production image deletesnode_modulesright after building. A module now ships its own compiled JS, which core loads as a third source in the page resolver.1a339fbf— a failing module no longer takes the whole application down. An exception thrown in a provider'sboot()escaped thetry/catcharound registration and took every route with it — including the admin screen needed to disable the offending module, so recovery meant deleting its directory by hand.Also: one section instead of nine headings
Every merged branch appended its own
### Added/### Fixed/### Changed, soUnreleasedhad nine headings and the same kind of change appeared in three separate places. Folded back into one of each, with the entries themselves untouched.The diff looks larger than it is: most of it is lines moving between headings.