-
Notifications
You must be signed in to change notification settings - Fork 5
Add NAME cdl files #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mo-marqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detail comment on quantity definition, naming, units, etc. for scientific data variables
| TCID50_AIR_CONCENTRATION:long_name = "TCID50_AIR_CONCENTRATION" ; | ||
| TCID50_AIR_CONCENTRATION:grid_mapping = "latitude_longitude" ; | ||
| TCID50_AIR_CONCENTRATION:field_name = "Unnamed Field Req 1" ; | ||
| TCID50_AIR_CONCENTRATION:units = "TCID50 s / m^3" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
udunits2: Don't recognize "TCID50 s / m^3"
what unit of measure in SI terms is being represented here?
| latitude_longitude:grid_mapping_name = "latitude_longitude" ; | ||
| latitude_longitude:longitude_of_prime_meridian = 0.f ; | ||
| latitude_longitude:earth_radius = 6371229.f ; | ||
| float TCID50_AIR_CONCENTRATION(latitude, longitude) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no standard_name
what is the quantity here?
| float TCID50_AIR_CONCENTRATION(latitude, longitude) ; | ||
| TCID50_AIR_CONCENTRATION:long_name = "TCID50_AIR_CONCENTRATION" ; | ||
| TCID50_AIR_CONCENTRATION:grid_mapping = "latitude_longitude" ; | ||
| TCID50_AIR_CONCENTRATION:field_name = "Unnamed Field Req 1" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unamed fireld req 1 seems a bit obtuse
| latitude_longitude:longitude_of_prime_meridian = 0.f ; | ||
| latitude_longitude:earth_radius = 6371229.f ; | ||
| float VOLCANIC_ASH_AIR_CONCENTRATION(flight_level, latitude, longitude) ; | ||
| VOLCANIC_ASH_AIR_CONCENTRATION:long_name = "VOLCANIC_ASH_AIR_CONCENTRATION" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no standard_name
| float VOLCANIC_ASH_AIR_CONCENTRATION(flight_level, latitude, longitude) ; | ||
| VOLCANIC_ASH_AIR_CONCENTRATION:long_name = "VOLCANIC_ASH_AIR_CONCENTRATION" ; | ||
| VOLCANIC_ASH_AIR_CONCENTRATION:grid_mapping = "latitude_longitude" ; | ||
| VOLCANIC_ASH_AIR_CONCENTRATION:field_name = "Unnamed Field Req 1" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear laebl
| TCID50_AIR_CONCENTRATION:time_av_int_info = "1day 0hr 0min integral" ; | ||
| TCID50_AIR_CONCENTRATION:vertical_av_int_info = "Boundary layer average" ; | ||
| TCID50_AIR_CONCENTRATION:horizontal_av_int_info = "No horizontal averaging" ; | ||
| TCID50_AIR_CONCENTRATION:cell_methods = "time: sum" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cell method not consistent with non-convention av_int info notes (vertical averaging?)
| height:bounds = "height_bnds" ; | ||
| float height_bnds(nbounds) ; | ||
| height_bnds:long_name = "height above ground level start and end point" ; | ||
| float TRACER_AIR_CONCENTRATION(latitude, longitude) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no standard_names
| height:bounds = "height_bnds" ; | ||
| float height_bnds(nbounds) ; | ||
| height_bnds:long_name = "height above ground level start and end point" ; | ||
| float GRASS_POLLEN_CONCENTRATION(latitude, longitude) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no standard_name
number_concentration_of_biological_taxon_pollen_grains_in_air
"Number concentration" means the number of particles or other specified objects per unit volume. "Pollen grain" refers to the male gametophyte of seed plants (either angiosperms or gymnosperms). The number concentration of pollen grains refers to the number of individual pollen grains per unit volume. "Biological taxon" is a name or other label identifying an organism or a group of organisms as belonging to a unit of classification in a hierarchical taxonomy. There must be an auxiliary coordinate variable with standard name biological_taxon_name to identify the taxon in human readable format and optionally an auxiliary coordinate variable with standard name biological_taxon_identifier to provide a machine-readable identifier. See Section 6.1.2 of the CF convention (version 1.8 or later) for information about biological taxon auxiliary coordinate variables.
is available, but is a number concentration, not a mass concentration
| height:bounds = "height_bnds" ; | ||
| float height_bnds(nbounds) ; | ||
| height_bnds:long_name = "height above ground level start and end point" ; | ||
| float CAESIUM_137_AIR_CONCENTRATION(latitude, longitude) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| CAESIUM_137_AIR_CONCENTRATION:vertical_av_int_info = "Finite Z-average" ; | ||
| CAESIUM_137_AIR_CONCENTRATION:horizontal_av_int_info = "No horizontal averaging" ; | ||
| CAESIUM_137_AIR_CONCENTRATION:cell_methods = "time: sum height: mean" ; | ||
| float CAESIUM_137_DEPOSITION(latitude, longitude) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no standard_name CF does not yet include deposition for caesium
mo-marqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on position in space
some issues exist with coordinate variable missing data and uncertainty about the intent of the grid-mapping coordinate reference system for the latitude and longitude coordinate
| latitude:standard_name = "latitude" ; | ||
| latitude:units = "degrees_north" ; | ||
| latitude:axis = "Y" ; | ||
| latitude:valid_min = 53.02476f ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing data is not allowed within coordinate variables.
what is the intent of defining valid_min for these spatial coordinate varaiables?
https://cfconventions.org/Data/cf-conventions/cf-conventions-1.13/cf-conventions.html#missing-data
| forecast_reference_time:calendar = "gregorian" ; | ||
| char z_bla(string23) ; | ||
| z_bla:long_name = "z" ; | ||
| int latitude_longitude ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this grid_mapping defines a spherical earth for spatial coordinates, is that the intent?
| longitude:standard_name = "longitude" ; | ||
| longitude:units = "degrees_east" ; | ||
| longitude:axis = "X" ; | ||
| longitude:valid_min = -2.663774f ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coordinate variable
| latitude:standard_name = "latitude" ; | ||
| latitude:units = "degrees_north" ; | ||
| latitude:axis = "Y" ; | ||
| latitude:valid_min = -89.875f ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
| longitude:standard_name = "longitude" ; | ||
| longitude:units = "degrees_east" ; | ||
| longitude:axis = "X" ; | ||
| longitude:valid_min = -179.875f ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
| flight_level:long_name = "flight level" ; | ||
| flight_level:axis = "Z" ; | ||
| flight_level:positive = "up" ; | ||
| flight_level:valid_min = 25.f ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coordinate variable should not define missing data, valid-min etc.
To aid visibility and discussion on native NAME NetCDF output, I am going to add the .cdl files to this repository.