refactor: Rebuild OneLinkService(s) and bump major version to 1.0.x - #4
tareksabry1337 wants to merge 4 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| push: | ||
| branches: | ||
| - 'main' | ||
| - 'revamp/parameter-pasrsing' |
There was a problem hiding this comment.
Bug: Development Branch Leaked Into Production
The workflow includes a temporary development branch revamp/parameter-pasrsing (note the typo "pasrsing" instead of "parsing"). This appears to be temporary debug/development configuration that shouldn't be in a production release workflow, especially given the PR is about bumping to version 1.0.x.
| data object HttpStatusCode : DeepLinkError() | ||
| data object Unexpected : DeepLinkError() | ||
| data object DeveloperError : DeepLinkError() | ||
| data class Generic(override val message: String) : DeepLinkError(message) |
There was a problem hiding this comment.
Bug: Platform Mismatch Blocks Error Details.
Platform mismatch in DeepLinkError implementation. Android uses an open class with nested subclasses (Timeout, Network, etc.), while iOS uses a data class with an NSError parameter. The Android implementation's data objects don't pass values to the parent constructor's message parameter, making the error details inaccessible through the base class on Android, breaking cross-platform API consistency.
1 participant
Note
Reworks AppsFlyer deep-linking to a structured DeepLinkResult with new helpers and listener callbacks across Android/iOS, expands constants, and updates CI to publish 1.0.x.
DeepLinkResultwith structured nested fields (Origin,Campaign,Advertisement, etc.) and addDeepLinkResult.notFound().DeepLinkHelpersto parse/build deep-link data (getDeepLinkValue,parseDestination,build*mappers).onAppAttributionand nullable result; addonAttributionDataandonDeepLinkNotFound;onDeepLinkingResultnow requires aDeepLinkResult.DeepLinkErrorwithmessageandGeneric; map SDK errors viatoError().is_first_launch; passclickEvent/conversion; unify NOT_FOUND handling and error callbacks.AppsFlyerConstants; update deep-link value generation to useAF_CHANNEL.revamp/parameter-pasrsingand bump publish version to1.0.${{ github.run_number }}.Written by Cursor Bugbot for commit 85e7a5d. This will update automatically on new commits. Configure here.