Skip to content

Conversation

@ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Jan 22, 2026

Tron swaps use async settlement and need polling to get the destination tx hash. This is used to filter duplicate receive transactions in the activity list.

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Enables async settlement handling for Tron same-chain swaps by starting status polling and refining when polling is (re)started.

  • Introduces #shouldPollHistoryItem to centralize polling decisions (polls for bridge, intent, and Tron same-chain swaps) and uses it in resume/restart polling paths
  • In submitTx, detects isTronSameChainSwap, starts polling for non-EVM, and avoids immediate Completed tracking for Tron same-chain swaps (will complete via polling)
  • Exports isTronChainId from bridge-controller for use in status controller
  • Updates tests and snapshots to assert polling behavior for Tron swaps and adjust expected calls

Written by Cursor Bugbot for commit 1da7003. This will update automatically on new commits. Configure here.

  Tron swaps use async settlement and need polling to get the destination
  tx hash. This is used to filter duplicate receive transactions in the
  activity list.
@ghgoodreau ghgoodreau requested a review from a team as a code owner January 22, 2026 03:31
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

@ghgoodreau ghgoodreau marked this pull request as draft January 22, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants