generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(omnium): Add controller architecture #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rekmarks
wants to merge
18
commits into
main
Choose a base branch
from
rekm/controller-architecture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,512
−26
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f166b3d
feat(omnium): Add controller architecture and CapletController
rekmarks 83c867d
refactor(omnium): Simplify CapletController state structure
rekmarks 93705fc
refactor(omnium): Add abstract Controller base class
rekmarks 3f498e6
refactor(omnium): Refactor ControllerStorage with debounced persistence
rekmarks c755a35
refactor(omnium): Simplify CapletId validation to allow any ASCII string
rekmarks e8bc97c
chore: Update coverage
rekmarks e359423
refactor: Fix omnium background globals
rekmarks 1ab49c9
refactor: Always close the offscreen stream on startup failure
rekmarks 9583876
Merge branch 'main' into rekm/controller-architecture
rekmarks 1fcacb5
refactor: Address bugbot review
rekmarks a43c7f2
refactor: Remove caplet services
rekmarks ebdbb3d
fix: Decrease wait times in logger ipc test
rekmarks b6e2f19
refactor: Clean up some controller code
rekmarks f3b866b
test: Improve controller test reliability and add error handling tests
rekmarks e015435
refactor(controllers): Simplify test setup and remove facet abstraction
rekmarks 60c609e
Merge branch 'main' into rekm/controller-architecture
rekmarks bd6bfea
docs: Add TODO for caplet manifest validation
rekmarks 94e4677
fix: Fix omnium.caplet types
rekmarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incidental change after the root
test:devwas failing due to these timeouts being needlessly long.