Skip to content

⚡ Bolt: Optimize voter diffing with O(1) Set lookups - #375

Draft
yeboster wants to merge 1 commit into
mainfrom
bolt-optimize-voter-filtering-9028590220454430785
Draft

⚡ Bolt: Optimize voter diffing with O(1) Set lookups#375
yeboster wants to merge 1 commit into
mainfrom
bolt-optimize-voter-filtering-9028590220454430785

Conversation

@yeboster

Copy link
Copy Markdown
Contributor

💡 What: Replaced Array.prototype.includes() inside an Array.prototype.filter() loop with an $O(1)$ Set.prototype.has() lookup in both /api/proposals/voters/add and /api/proposals/voters/remove.
🎯 Why: Iterating over a potentially large list of owners and performing an $O(N)$ lookup on voters (and vice-versa) leads to an $O(N \times M)$ performance bottleneck that synchronously blocks the main thread.
📊 Impact: Reduces array intersection complexity from $O(N \times M)$ to $O(N + M)$, ensuring endpoints remain fast and responsive regardless of how large the voter and owner arrays grow.
🔬 Measurement: Verified logic via unit tests. Run a local profiling session before and after the change with arrays of 5000 elements to observe the immediate reduction in main-thread blocking time.


PR created automatically by Jules for task 9028590220454430785 started by @yeboster

Replaces inefficient O(N*M) Array.includes lookups with O(1) Set lookups in proposals voters add and remove endpoints. This prevents the main thread from blocking when diffing large arrays of voters and owners.

Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Error Error Jun 25, 2026 7:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant