Skip to content

🎨 Palette: [UX improvement] - Profile search accessibility and filter bug fix - #379

Draft
yeboster wants to merge 1 commit into
mainfrom
palette-ux-profile-search-icon-16019892818908916410
Draft

🎨 Palette: [UX improvement] - Profile search accessibility and filter bug fix#379
yeboster wants to merge 1 commit into
mainfrom
palette-ux-profile-search-icon-16019892818908916410

Conversation

@yeboster

Copy link
Copy Markdown
Contributor

💡 What:

  1. Conditionally renders the clear icon in the domain search Textfield so it only appears when there's text to clear.
  2. Fixes a bug in the reactive search filter that prevented the domain list from resetting when the search input was cleared.
  3. Adds .jules/ and static/ to .prettierignore to prevent auto-formatting failures on generated files.

🎯 Why:

  1. Empty clear buttons shouldn't receive keyboard focus as it causes unnecessary tab stops for keyboard navigation.
  2. The domain list failed to show all domains again once the user deleted their search query, frustrating users.
  3. The codebase pnpm run format command was failing because it attempted to format newly generated .jules/palette.md and compiled static/ fonts.

📸 Before/After: Visual change is minor (clear icon disappears when input is empty).

Accessibility:

  • Replaced the generic aria-label="cancel" with a more contextually accurate aria-label="clear search" for screen reader users.
  • Empty icon container is removed from the DOM so it cannot receive keyboard focus, reducing tab fatigue.

PR created automatically by Jules for task 16019892818908916410 started by @yeboster

…reset

* Conditionally render trailing clear icon in Textfield
* Use 'clear search' aria-label instead of generic 'cancel'
* Dynamically bind withTrailingIcon property to preserve layout
* Add missing 'else' statement to reset filtered domains when search is empty
* Add .jules/ and static/ to .prettierignore

Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 27, 2026 8:17pm

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant