Skip to content

🎨 Palette: Improve profile search field UX and Accessibility - #385

Draft
yeboster wants to merge 1 commit into
mainfrom
palette-ux-search-field-profile-13890238236626302293
Draft

🎨 Palette: Improve profile search field UX and Accessibility#385
yeboster wants to merge 1 commit into
mainfrom
palette-ux-search-field-profile-13890238236626302293

Conversation

@yeboster

Copy link
Copy Markdown
Contributor
  • 💡 What: Conditionally render the trailing clear icon so it's not focusable when empty, by using {#if search !== ''} and withTrailingIcon={search !== ''}. Change the aria-label of the clear button to a more descriptive "clear search". Add an else block to reset the domainsFiltered variable when the search input is empty. Fixed an implicit return bug in the fuzzy matching function.
  • 🎯 Why: This improves keyboard navigation accessibility by removing a focusable element that does nothing when the input is empty. The aria-label is also more descriptive. Resetting the domainsFiltered variable ensures the filtered data behaves correctly.
  • 📸 Before/After: Visual change in the search bar. When the search is empty, the trailing clear icon is hidden.
  • ♿ Accessibility: Improved keyboard navigation and screen reader accessibility by hiding empty interactive elements and using a more descriptive aria-label.

PR created automatically by Jules for task 13890238236626302293 started by @yeboster

- Hide trailing clear icon when search is empty to remove focusable element
- Update aria-label to 'clear search' for better screen reader context
- Reset domainsFiltered when search is empty
- Fix return value in fuzzy matcher

Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 30, 2026 8:40pm

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant