🎨 Palette: Improve profile search field UX and Accessibility - #385
🎨 Palette: Improve profile search field UX and Accessibility#385yeboster wants to merge 1 commit into
Conversation
- Hide trailing clear icon when search is empty to remove focusable element - Update aria-label to 'clear search' for better screen reader context - Reset domainsFiltered when search is empty - Fix return value in fuzzy matcher Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
{#if search !== ''}andwithTrailingIcon={search !== ''}. Change thearia-labelof the clear button to a more descriptive "clear search". Add anelseblock to reset thedomainsFilteredvariable when thesearchinput is empty. Fixed an implicit return bug in the fuzzy matching function.aria-labelis also more descriptive. Resetting thedomainsFilteredvariable ensures the filtered data behaves correctly.aria-label.PR created automatically by Jules for task 13890238236626302293 started by @yeboster