forked from deepseek-ai/FlashMLA
-
Notifications
You must be signed in to change notification settings - Fork 3
延迟生成 benchmark 形状 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghangz
wants to merge
1
commit into
MetaX-MACA:main
Choose a base branch
from
ghangz:mengz/lazy-benchmark-shapes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import ast | ||
| import unittest | ||
| from pathlib import Path | ||
|
|
||
|
|
||
| BENCHMARK = Path(__file__).parents[1] / "benchmark" / "bench_flash_mla.py" | ||
|
|
||
|
|
||
| class BenchmarkShapeConfigTest(unittest.TestCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| cls.tree = ast.parse(BENCHMARK.read_text(encoding="utf-8")) | ||
|
|
||
| def test_shape_configs_are_not_created_at_import_time(self): | ||
| top_level_assigns = [ | ||
| node | ||
| for node in self.tree.body | ||
| if isinstance(node, ast.Assign) | ||
| and any( | ||
| isinstance(target, ast.Name) and target.id == "shape_configs" | ||
| for target in node.targets | ||
| ) | ||
| ] | ||
|
|
||
| self.assertEqual(top_level_assigns, []) | ||
|
|
||
| def test_shape_builder_accepts_device_argument(self): | ||
| builder = next( | ||
| node | ||
| for node in self.tree.body | ||
| if isinstance(node, ast.FunctionDef) and node.name == "build_shape_configs" | ||
| ) | ||
|
|
||
| self.assertEqual(builder.args.args[0].arg, "device") | ||
| self.assertEqual(builder.args.defaults[0].value, "cuda") | ||
|
|
||
| def test_main_creates_shape_configs_lazily(self): | ||
| main_block = next( | ||
| node | ||
| for node in self.tree.body | ||
| if isinstance(node, ast.If) | ||
| and isinstance(node.test, ast.Compare) | ||
| and isinstance(node.test.left, ast.Name) | ||
| and node.test.left.id == "__name__" | ||
| ) | ||
| calls = [node for node in ast.walk(main_block) if isinstance(node, ast.Call)] | ||
|
|
||
| self.assertTrue( | ||
| any( | ||
| isinstance(call.func, ast.Name) and call.func.id == "build_shape_configs" | ||
| for call in calls | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在测试中,直接使用
builder.args.defaults[0].value来获取默认值虽然在 Python 3.8+ 中可行,但使用ast.literal_eval是一种更通用、更安全且兼容性更好的方式来解析 AST 中的字面量值。建议将其替换为ast.literal_eval(builder.args.defaults[0])。