Skip to content

Dto's for software registry#350

Open
MikaelPL1 wants to merge 8 commits into
developfrom
349-dtos-for-software-registry
Open

Dto's for software registry#350
MikaelPL1 wants to merge 8 commits into
developfrom
349-dtos-for-software-registry

Conversation

@MikaelPL1
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 11, 2026 12:49
@MikaelPL1 MikaelPL1 linked an issue Mar 11, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces DTO mapping for the Software Registry lambdas so API responses align with the generated SoftwareRegistry model (notably converting timestamp fields), and adjusts the persisted software model timestamp types to match DynamoDB storage.

Changes:

  • Added dtoToEntity / entityToDto mappers for SoftwareRegistrySoftwareModel.
  • Updated create/list/update software handlers to use the new mappers for response/request shaping.
  • Changed SoftwareModel.createdAt / lastUpdatedAt types from Date to string.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/functions/software-registry/update-software/handler.ts Returns the updated record via entityToDto before serializing.
src/functions/software-registry/list-software/handler.ts Uses entityToDto for list responses instead of inline mapping.
src/functions/software-registry/create-software/handler.ts Converts DTO→entity before create, and entity→DTO on response.
src/database/models/software.ts Aligns timestamp fields with DynamoDB (ISO string) representation.
src/database/dtos/softwareRegistryDtos.ts Adds centralized mapping functions for the software registry types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/functions/software-registry/update-software/handler.ts
Comment thread src/functions/software-registry/create-software/handler.ts
Comment thread src/database/models/software.ts Outdated
Comment thread src/database/dtos/softwareRegistryDtos.ts
Comment thread src/database/dtos/softwareRegistryDtos.ts
Comment thread src/functions/software-registry/list-software/handler.ts
Comment thread src/database/models/software.ts Outdated
Comment thread src/functions/software-registry/create-software/handler.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/functions/software-registry/create-software/handler.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/functions/software-registry/create-software/handler.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/functions/software-registry/create-software/handler.ts
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DTO's for software registry

5 participants