Conversation
Prevents edge case crashes
Not used yet, but I plan on refactoring a bunch to use it. I *really* need to plan things before trying to just riff a project as complex as this. I've moved MixedType as well
Alright, so this was a big sweep of changes. After all that slab context work, I removed the concept entirely in favor of an interface called SlabLike that lets you do slab operations. This also removed all the forwarding functions built into MixedSlabBlock, and moved most of the Utility functions out of that class into SlabLike. Why I didn't do this from the start, the world may never know. Also of note, fixed a compat bug with Mo Glass
It just wasn't getting called, it was calling the base block version. No behavior change for existing slabs, but would've caused problems if any handler needed it
The release isn't tied to tags anymore, it's a manual thing so I can set up a changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked huge parts of the back-end
SlabContextentirely, it was janky and unnecessaryMixedSlabBlockfor the same reasonsSlabLikeinterface thatMixedSlabBlock,VerticalSlabBlock, andSlabBlockall inherit fromUtilityfunctions have either been removed or moved intoSlabLikeSlabLikeinsteadMixedHandlerbug whereplayerDestroywasn't being correctly called. It didn't cause problems yet because nothing needed it, but it would've been a problem for future compat.