Skip to content

Feat/20 add prometheus - #21

Merged
Sehi55 merged 3 commits into
devfrom
feat/20-add-prometheus
May 17, 2026
Merged

Sehi55 merged 3 commits into
devfrom
feat/20-add-prometheus

Conversation

@Sehi55

@Sehi55 Sehi55 commented May 17, 2026

Copy link
Copy Markdown
Contributor

📝 작업 내용

이번 PR에서 작업한 내용을 설명해주세요.

  • 프로메테우스 의존성 추가

🚀 주요 변경 사항

완료한 이슈 번호
Close #20
관련된 이슈 번호 (닫고 싶지 않은 경우)
Related to #

Summary by CodeRabbit

  • Chores
    • 애플리케이션 모니터링 및 메트릭 수집 기능이 강화되었습니다.

Review Change Stack

Sehi55 and others added 3 commits May 17, 2026 04:13
@Sehi55 Sehi55 self-assigned this May 17, 2026
@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b71f4884-2250-4361-aef6-b4a9d2f97990

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/20-add-prometheus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
build.gradle (1)

25-25: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

중복된 Actuator 의존성을 제거하세요.

spring-boot-starter-actuator 의존성이 25번 라인과 41번 라인에 중복으로 선언되어 있습니다. 하나를 제거하여 빌드 설정을 정리하는 것이 좋습니다.

♻️ 중복 제거 제안
 	implementation 'org.springframework.boot:spring-boot-starter-actuator'
 	implementation 'org.springframework.cloud:spring-cloud-starter-gateway-server-webflux'
 	implementation 'org.springframework.cloud:spring-cloud-starter-netflix-eureka-client'

 	implementation 'io.jsonwebtoken:jjwt-api:0.12.6'
 	runtimeOnly 'io.jsonwebtoken:jjwt-impl:0.12.6'
 	runtimeOnly 'io.jsonwebtoken:jjwt-jackson:0.12.6'

 	implementation 'org.springframework.boot:spring-boot-starter-oauth2-resource-server'
 	implementation 'org.springframework.boot:spring-boot-starter-security'

 	testImplementation 'org.springframework.boot:spring-boot-starter-test'
 	testImplementation 'io.projectreactor:reactor-test'
 	testImplementation 'org.springframework.security:spring-security-test'
 	testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

-	implementation 'org.springframework.boot:spring-boot-starter-actuator'
 	implementation 'io.micrometer:micrometer-registry-prometheus'

Also applies to: 41-41

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@build.gradle` at line 25, Remove the duplicate dependency declaration for
"org.springframework.boot:spring-boot-starter-actuator" by keeping a single
implementation line and deleting the redundant one; locate the two identical
dependency entries (the implementation
'org.springframework.boot:spring-boot-starter-actuator' lines) and remove one so
only one actuator dependency remains in the Gradle dependencies block.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@build.gradle`:
- Line 25: Remove the duplicate dependency declaration for
"org.springframework.boot:spring-boot-starter-actuator" by keeping a single
implementation line and deleting the redundant one; locate the two identical
dependency entries (the implementation
'org.springframework.boot:spring-boot-starter-actuator' lines) and remove one so
only one actuator dependency remains in the Gradle dependencies block.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9857879d-4521-46bd-881c-49d11036b973

📥 Commits

Reviewing files that changed from the base of the PR and between 7b95d07 and eb685c6.

📒 Files selected for processing (1)
  • build.gradle

@Sehi55
Sehi55 merged commit a414bd8 into dev May 17, 2026
4 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant