feat: docker setting - #4
Merged
Merged
Conversation
Closed
2 tasks
📝 Walkthrough개요다단계 Dockerfile을 추가하여 Gradle을 통해 Spring Boot JAR을 빌드하고, Docker 환경을 위한 Eureka 클라이언트 구성을 정의합니다. 프로젝트명을 'gateway'에서 'api-gateway'로 변경하고 구성 파일을 정리합니다. 변경사항
예상 코드 리뷰 시간🎯 1 (사소함) | ⏱️ ~5분 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
requested review from
Jinyoung-Kim96,
githyj-jang,
ji-circle,
jihxonx and
qldo
April 27, 2026 06:22
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Around line 12-19: The runtime Dockerfile runs as root because there is no
USER set; create a non-root runtime user and switch to it by adding a user/group
(e.g., "appuser"), ensure the /app directory and the copied app.jar are owned by
that user (or use --chown during COPY from builder or run chown /app), then add
a USER appuser directive before ENTRYPOINT so java -jar /app/app.jar runs with
least privilege; keep the existing FROM, WORKDIR, COPY and ENTRYPOINT lines but
update ownership and add the USER declaration.
- Line 19: The Dockerfile currently only sets ENTRYPOINT ["java", "-jar",
"/app/app.jar"] which doesn't activate the docker Spring profile; update the
Dockerfile to set the docker profile either by adding an environment variable
SPRING_PROFILES_ACTIVE=docker (ENV SPRING_PROFILES_ACTIVE=docker) or by
appending the JVM system property to the ENTRYPOINT (e.g., add
-Dspring.profiles.active=docker to the java command) so application-docker.yml
(Eureka config) is loaded inside the container.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9738af95-7ce8-4b97-a95b-ef1dec734121
📒 Files selected for processing (4)
Dockerfilesettings.gradlesrc/main/resources/application-docker.ymlsrc/main/resources/application-local.yml
💤 Files with no reviewable changes (1)
- src/main/resources/application-local.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
Release Notes