Skip to content

[Chore] 서비스들 라우트 정보 추가 - #6

Merged
Sehi55 merged 2 commits into
devfrom
chore/5-service-routes-setting
Apr 29, 2026
Merged

Sehi55 merged 2 commits into
devfrom
chore/5-service-routes-setting

Conversation

@Sehi55

@Sehi55 Sehi55 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📝 작업 내용

이번 PR에서 작업한 내용을 설명해주세요.

🚀 주요 변경 사항

완료한 이슈 번호
Close #5
관련된 이슈 번호 (닫고 싶지 않은 경우)
Related to #

✅ 자체 체크리스트 (필수)

  • ./gradlew build 실행 결과 정상 (인증샷 첨부)

📸 테스트 인증샷

image

💬 리뷰어 전달사항 (선택)

특별히 봐주었으면 하는 부분이나 논의가 필요한 점을 적어주세요.

  • 논의점


📎 참고 자료

관련 문서, 레퍼런스 링크 등이 있다면 여기에 첨부해주세요.

Summary by CodeRabbit

새로운 기능

  • API 엔드포인트 업데이트
    • 사용자 서비스 API 경로가 변경되었습니다 (/api/v1/users/**, /api/v1/admin/users/**)
    • 예약, 레스토랑, 결제, 주문, 알림, 인벤토리, 카탈로그, 시간대, 대기 서비스가 게이트웨이를 통해 사용 가능합니다
    • 모든 API가 /api/v1/**/api/v1/admin/** 형식으로 통일되었습니다

@Sehi55 Sehi55 self-assigned this Apr 28, 2026
@Sehi55 Sehi55 added the enhancement New feature or request label Apr 28, 2026
@Sehi55 Sehi55 linked an issue Apr 28, 2026 that may be closed by this pull request
1 task
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

API Gateway의 라우팅 설정을 업데이트하여 user-service 경로를 /api/v1/** 패턴으로 변경하고, timeslots, restaurants, reservations, catalogs, inventory, orders, waiting, notifications, payments 등 9개 마이크로서비스 라우트를 새로 추가합니다.

Changes

Cohort / File(s) Summary
게이트웨이 라우팅 설정
src/main/resources/application.yml
user-service 라우트를 /api/v1/users/**/api/v1/admin/users/**로 변경하고, timeslots, restaurants, reservations, catalogs, inventory(admin 전용), orders, waiting, notifications, payments 서비스를 위한 9개의 새로운 라우트 추가. 모든 라우트는 lb:// 로드밸런싱 기반 서비스 호출 방식 사용.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • ji-circle
  • Jinyoung-Kim96
  • jihxonx

Poem

🐰 마이크로 서비스, 길을 찾아요
API 게이트웨이가 길잡이 되어
아홉 가지 길을 활짝 열었어요
사용자부터 결제까지, 모두 반겨요
라우팅의 정글 속 토끼의 환호! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경 사항을 명확하게 설명하고 있으며, 마이크로서비스 라우트 정보 추가라는 주요 변경 사항을 정확히 반영하고 있습니다.
Linked Issues check ✅ Passed PR에서 수행한 코드 변경사항들이 #5 이슈의 요구사항인 'application.yml 추가'를 완벽하게 충족하고 있습니다.
Out of Scope Changes check ✅ Passed application.yml 파일의 라우트 설정만 변경되었으며, #5 이슈의 마이크로서비스 라우트 설정 범위 내의 변경사항으로만 구성되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/5-service-routes-setting

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/resources/application.yml (1)

16-25: 중첩 경로에 대해 명시적 order 값으로 우선순위를 고정하세요.

timeslot-service의 경로(/api/v1/restaurants/*/time-slots/**)가 restaurant-service의 상위 패턴(/api/v1/restaurants/**)에 포함되므로, 현재 선언 순서에 의존하고 있습니다. 라우트 순서 변경 시 잘못된 라우팅 위험이 발생할 수 있으므로 order 값을 명시적으로 설정하는 것이 권장됩니다.

♻️ 제안 수정안
             - id: timeslot-service
+              order: -20
               uri: lb://TIMESLOT-SERVICE
               predicates:
                 - Path=/api/v1/restaurants/*/time-slots/**,/api/v1/admin/restaurants/*/time-slots/**
 
             - id: restaurant-service
+              order: -10
               uri: lb://RESTAURANT-SERVICE
               predicates:
                 - Path=/api/v1/restaurants/**,/api/v1/admin/restaurants/**
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/main/resources/application.yml` around lines 16 - 25, The routes rely on
declaration order and must use explicit ordering: add an order field to the
route definitions so timeslot-service gets a higher priority (lower numeric
order) than restaurant-service; specifically add something like order: 1 to the
route with id timeslot-service (Path=/api/v1/restaurants/*/time-slots/**) and
order: 2 to the route with id restaurant-service (Path=/api/v1/restaurants/**)
to ensure the more specific timeslot-service route always matches before the
broader restaurant-service route.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/main/resources/application.yml`:
- Around line 16-25: The routes rely on declaration order and must use explicit
ordering: add an order field to the route definitions so timeslot-service gets a
higher priority (lower numeric order) than restaurant-service; specifically add
something like order: 1 to the route with id timeslot-service
(Path=/api/v1/restaurants/*/time-slots/**) and order: 2 to the route with id
restaurant-service (Path=/api/v1/restaurants/**) to ensure the more specific
timeslot-service route always matches before the broader restaurant-service
route.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d325ed4-8626-473d-a666-30fba17c61a3

📥 Commits

Reviewing files that changed from the base of the PR and between 3094136 and 80c5170.

📒 Files selected for processing (1)
  • src/main/resources/application.yml

@Jinyoung-Kim96 Jinyoung-Kim96 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@ji-circle ji-circle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@Sehi55
Sehi55 merged commit 13fbf34 into dev Apr 29, 2026
4 checks passed
@Sehi55
Sehi55 deleted the chore/5-service-routes-setting branch April 29, 2026 01:24
@coderabbitai coderabbitai Bot mentioned this pull request May 6, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] 마이크로 서비스들 라우트 설정

3 participants