[Chore] 서비스들 라우트 정보 추가 - #6
Conversation
📝 WalkthroughWalkthroughAPI Gateway의 라우팅 설정을 업데이트하여 user-service 경로를 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/resources/application.yml (1)
16-25: 중첩 경로에 대해 명시적order값으로 우선순위를 고정하세요.
timeslot-service의 경로(/api/v1/restaurants/*/time-slots/**)가restaurant-service의 상위 패턴(/api/v1/restaurants/**)에 포함되므로, 현재 선언 순서에 의존하고 있습니다. 라우트 순서 변경 시 잘못된 라우팅 위험이 발생할 수 있으므로order값을 명시적으로 설정하는 것이 권장됩니다.♻️ 제안 수정안
- id: timeslot-service + order: -20 uri: lb://TIMESLOT-SERVICE predicates: - Path=/api/v1/restaurants/*/time-slots/**,/api/v1/admin/restaurants/*/time-slots/** - id: restaurant-service + order: -10 uri: lb://RESTAURANT-SERVICE predicates: - Path=/api/v1/restaurants/**,/api/v1/admin/restaurants/**🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/resources/application.yml` around lines 16 - 25, The routes rely on declaration order and must use explicit ordering: add an order field to the route definitions so timeslot-service gets a higher priority (lower numeric order) than restaurant-service; specifically add something like order: 1 to the route with id timeslot-service (Path=/api/v1/restaurants/*/time-slots/**) and order: 2 to the route with id restaurant-service (Path=/api/v1/restaurants/**) to ensure the more specific timeslot-service route always matches before the broader restaurant-service route.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/main/resources/application.yml`:
- Around line 16-25: The routes rely on declaration order and must use explicit
ordering: add an order field to the route definitions so timeslot-service gets a
higher priority (lower numeric order) than restaurant-service; specifically add
something like order: 1 to the route with id timeslot-service
(Path=/api/v1/restaurants/*/time-slots/**) and order: 2 to the route with id
restaurant-service (Path=/api/v1/restaurants/**) to ensure the more specific
timeslot-service route always matches before the broader restaurant-service
route.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d325ed4-8626-473d-a666-30fba17c61a3
📒 Files selected for processing (1)
src/main/resources/application.yml
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
새로운 기능
/api/v1/users/**,/api/v1/admin/users/**)/api/v1/**및/api/v1/admin/**형식으로 통일되었습니다