Chore/40 catalog cicd prometheus - cd - #44
Conversation
📝 Walkthrough워크스루세 가지 독립적인 변경사항이 결합되어 프로덕션 배포 인프라를 구성한다: CI 워크플로우를 dev 브랜치로 확장, 새로운 프로덕션 배포 워크플로우 추가(AWS ECS에 이미지 배포), 헬스 체크 및 프로메테우스 모니터링 엔드포인트에 대한 무인증 접근 허용. 변경사항프로덕션 배포 파이프라인
추정 코드 리뷰 난이도🎯 3 (보통) | ⏱️ ~25분 관련 가능성 있는 PR
제안 리뷰어
시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cd-prod.yml:
- Around line 88-91: The workflow is injecting sensitive values as plain
environment variables (JWT_SECRET, INTERNAL_AUTH_SECRET, PERSONAL_INFO_SECRET)
which embeds them in the ECS task definition; instead, change the CD pipeline to
stop passing these via --arg/ENV and use ECS secrets integration with AWS
Secrets Manager or SSM Parameter Store: store each secret in Secrets
Manager/SSM, update the task definition JSON to remove those env entries and add
a "secrets" block that maps "JWT_SECRET", "INTERNAL_AUTH_SECRET",
"PERSONAL_INFO_SECRET" to their respective valueFrom ARNs/parameter ARNs, and
update the workflow step that builds the task definition to reference those ARNs
(do not interpolate the secret values into the file or call jq --arg with the
secret value).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6b9a72de-48c8-430d-9d79-ecf43da505a6
📒 Files selected for processing (3)
.github/workflows/cd-prod.yml.github/workflows/ci-prod.ymlsrc/main/java/com/michelet/catalog/infrastructure/config/SecurityConfig.java
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
릴리스 노트
New Features
Chores