fix: 프로메테우스 exposure추가 cd 수정 - #15
Conversation
📝 Walkthrough개요두 가지 프로덕션 환경 설정이 업데이트되었습니다: 애플리케이션 설정에서 프로메테우스 메트릭 엔드포인트 노출이 추가되었고, CD-PROD 배포 워크플로우는 단일 줄 조건식으로 정리되면서 변경 사항프로덕션 인프라 구성
코드 리뷰 예상 시간🎯 2 (Simple) | ⏱️ ~8분 토끼의 축시
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/application-prod.yml`:
- Line 22: application-prod.yml currently exposes Prometheus via the "include:
health,info,prometheus" setting which leaves /actuator/prometheus unprotected;
fix this by either adding Spring Security to the project and configuring access
control for the /actuator/prometheus endpoint (e.g., restrict to internal
roles/IPs) or by removing "prometheus" from the include list and
documenting/implementing explicit infra-level restrictions (firewall, network
policy or API gateway) to ensure /actuator/prometheus is accessible only from
trusted sources; update application-prod.yml and your project
dependency/configuration accordingly and add a short note in deployment docs
about the chosen protection method.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 24dc755e-e102-44c4-8ba0-d72fc41ace11
📒 Files selected for processing (2)
.github/workflows/cd-prod.ymlsrc/main/resources/application-prod.yml
📝 작업 내용
🚀 주요 변경 사항
Summary by CodeRabbit
릴리스 노트