feat/36 - fix: 주문 생성 부분도 비동기로 변경 - #37
Merged
Merged
Conversation
4 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughKafka의 주문 생성 메시지를 받아 OrderEventConsumer → StockLockFacade(정렬 기반 멀티락) → StockCommandService(트랜잭션 재고 차감, 멱등성 검사) 흐름으로 처리하고 결과를 Outbox의 ORDER_APPROVED/ORDER_REJECTED로 적재합니다. Changes주문 생성 비동기 처리 및 다중 재고 차감 흐름
Sequence DiagramsequenceDiagram
participant Kafka as Kafka (order-created)
participant Consumer as OrderEventConsumer
participant Lock as StockLockFacade
participant Command as StockCommandService
participant Repo as StockRepository
participant Outbox as InventoryOutbox
Kafka->>Consumer: OrderCreatedMessage
Consumer->>Lock: reserveOrderStocksWithLock(msg)
Lock->>Lock: 정렬된 optionId 리스트 생성
Lock->>Lock: sequential tryLock(stock:{optionId}, 5s)
Lock->>Command: processOrderCreation(msg)
Command->>Repo: 멱등성 검사(ProcessedEvent)
Command->>Repo: Stock.reserve(optionId, qty)
alt 품절 발생
Command->>Repo: Product.status = SOLDOUT
Command->>Outbox: append(PRODUCT_STATUS_CHANGED)
end
Command->>Repo: saveAll(Stocks)
Command->>Repo: save(ProcessedEvent)
alt 전체 성공
Command->>Outbox: append(ORDER_APPROVED)
else 비즈니스 실패
Command-->>Consumer: BusinessException
Consumer->>Outbox: appendIndependent(ORDER_REJECTED)
end
Lock->>Lock: finally: 역순 unlock
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
requested review from
Jinyoung-Kim96,
Sehi55,
jihxonx and
qldo
May 15, 2026 19:02
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
New Features
Refactor
Style/Validation