chore/42 - fix: cicd 코드 수정 - #43
Merged
Merged
Conversation
1 task
github-actions
Bot
requested review from
Jinyoung-Kim96,
Sehi55,
githyj-jang,
jihxonx and
qldo
May 19, 2026 06:26
📝 WalkthroughWalkthrough새 PR용 CI 워크플로우를 추가하고, 기존 프로덕션 빌드 워크플로우에서 pull request 트리거를 제거하며 조건부 실행 로직을 단순화했다. 동시에 배포 워크플로우를 dev 브랜치로 확장했다. ChangesCI/CD 파이프라인 재구조화
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
30-31: ⚡ Quick win테스트 결과 아티팩트 업로드 고려
현재 워크플로우는 테스트를 실행하지만 결과를 아티팩트로 저장하지 않습니다. 테스트 실패 시 GitHub UI에서 더 나은 가시성을 제공하기 위해 테스트 결과 게시를 추가하는 것을 고려해보세요.
📊 테스트 결과 게시 단계 추가 제안
- name: Run tests run: ./gradlew test --no-daemon + - name: Publish test results + if: always() + uses: actions/upload-artifact@v4 + with: + name: test-results + path: '**/build/test-results/test/TEST-*.xml'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 30 - 31, The workflow currently runs tests in the "Run tests" step (which runs ./gradlew test --no-daemon) but does not publish results; add a follow-up step (e.g., "Upload test results") that collects Gradle test outputs (glob '**/build/test-results/test/*.xml' and optionally '**/build/reports/tests/**') and publishes them using actions/upload-test-report (to surface results in the GitHub UI) and/or actions/upload-artifact (artifact name like "test-results") so test reports are available on failure and in the PR view.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cd-prod.yml:
- Line 34: The CD-PROD workflow is allowing the dev branch to deploy to
production via the condition "(github.event.workflow_run.head_branch == 'main'
|| github.event.workflow_run.head_branch == 'dev')", and uses
SPRING_PROFILES_ACTIVE="prod" plus ${vars.ECS_CLUSTER}/${vars.ECS_SERVICE};
remove 'dev' from the branch condition so CD-PROD only triggers for main, and if
dev deployments are needed create a separate cd-dev.yml workflow that uses
dev-specific profile/vars (set SPRING_PROFILES_ACTIVE="dev" and separate ECS
cluster/service or variables) rather than reusing the production
cluster/service.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 30-31: The workflow currently runs tests in the "Run tests" step
(which runs ./gradlew test --no-daemon) but does not publish results; add a
follow-up step (e.g., "Upload test results") that collects Gradle test outputs
(glob '**/build/test-results/test/*.xml' and optionally
'**/build/reports/tests/**') and publishes them using actions/upload-test-report
(to surface results in the GitHub UI) and/or actions/upload-artifact (artifact
name like "test-results") so test reports are available on failure and in the PR
view.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a9a0142b-ad76-429a-97b3-8c9871d0694c
📒 Files selected for processing (3)
.github/workflows/cd-prod.yml.github/workflows/ci-prod.yml.github/workflows/ci.yml
💤 Files with no reviewable changes (1)
- .github/workflows/ci-prod.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
릴리스 노트