Skip to content

fix/44 - Jsonserializer 수정 - #45

Merged
ji-circle merged 2 commits into
devfrom
fix/44-jsonSerializer-yml
May 19, 2026
Merged

fix/44 - Jsonserializer 수정#45
ji-circle merged 2 commits into
devfrom
fix/44-jsonSerializer-yml

Conversation

@ji-circle

@ji-circle ji-circle commented May 19, 2026

Copy link
Copy Markdown
Contributor

📝 작업 내용

이번 PR에서 작업한 내용을 설명해주세요.

  • 잘못 적었던 직렬화 관련 설정 수정

🚀 주요 변경 사항

완료한 이슈 번호
Close #44
관련된 이슈 번호 (닫고 싶지 않은 경우)
Related to #

✅ 자체 체크리스트 (필수)

  • ./gradlew build 실행 결과 정상 (인증샷 첨부)
  • 팀 내 컨벤션 준수 및 불필요한 로그, import 제거
  • 중요한 변경 사항이 팀에 공유되었는지

📸 테스트 인증샷

빌드 결과 및 IntelliJ HTTP Client 실행 화면을 여기에 첨부해 주세요.

💬 리뷰어 전달사항 (선택)

특별히 봐주었으면 하는 부분이나 논의가 필요한 점을 적어주세요.



📎 참고 자료

관련 문서, 레퍼런스 링크 등이 있다면 여기에 첨부해주세요.

Summary by CodeRabbit

  • Chores
    • Kafka 설정을 단순화하여 필수 구성 요소만 유지하도록 개선했습니다.
    • Spring 프로필 설정을 유연하게 변경하여 런타임에 프로필을 선택할 수 있도록 개선했습니다.

Review Change Stack

@ji-circle ji-circle added this to the 8. 기타 milestone May 19, 2026
@ji-circle ji-circle added the bug Something isn't working label May 19, 2026
@ji-circle ji-circle linked an issue May 19, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@ji-circle has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 42 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b1bbfa7-9a66-478f-91bb-fe94b3406e37

📥 Commits

Reviewing files that changed from the base of the PR and between c47c4d3 and 266aa05.

📒 Files selected for processing (1)
  • src/main/resources/application-prod.yml
📝 Walkthrough

Walkthrough

프로덕션 환경의 Kafka 설정과 애플리케이션 기본 프로필 구성을 단순화했습니다. Kafka producer/consumer 직렬화 설정을 제거하고, 기본 애플리케이션 프로필의 local 고정 설정을 제거하여 배포 유연성을 개선했습니다.

Changes

Kafka 설정 및 Spring 프로필 구성

Layer / File(s) Summary
Kafka 설정 단순화 및 프로필 제거
src/main/resources/application-prod.yml, src/main/resources/application.yml
프로덕션 Kafka 설정에서 기존 producer 직렬화 및 consumer 역직렬화 구성을 제거하고 bootstrap-servers와 consumer.group-id만 유지합니다. 기본 application.yml에서 spring.application.profiles.active: local 설정을 삭제하여 프로필 선택을 환경 변수나 시스템 속성으로 제어하도록 변경합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 설정의 불필요한 짐을 벗고,
직렬화 구성을 정리하며,
프로필도 자유롭게 선택하니—
배포가 한결 가벼워졌네! 🚀✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 'Jsonserializer 수정'으로 변경된 주요 내용인 직렬화 설정 수정을 명확하게 요약하고 있습니다.
Linked Issues check ✅ Passed 변경사항이 Issue #44의 목표인 '직렬화 관련 설정 수정'을 충족합니다. Kafka 설정에서 불필요한 직렬화/역직렬화 속성을 제거하여 올바르게 수정했습니다.
Out of Scope Changes check ✅ Passed 모든 변경사항이 직렬화 설정 수정과 관련된 범위 내에 있습니다. application-prod.yml의 Kafka 설정과 application.yml의 프로필 설정 제거는 모두 설정 정정에 해당합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/44-jsonSerializer-yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/resources/application-prod.yml`:
- Around line 19-22: The kafka block is mis-indented at root causing subsequent
spring properties (spring.jpa, spring.cloud) to be parsed under kafka;
move/indent the kafka: block so it is a child of the existing spring: root (same
level as jpa and cloud) — ensure keys like bootstrap-servers and
consumer.group-id remain under spring.kafka so spring.jpa.* and spring.cloud.*
are parsed correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 46dca3c4-dc62-4a9b-83af-acc63922ffcd

📥 Commits

Reviewing files that changed from the base of the PR and between b499ae4 and c47c4d3.

📒 Files selected for processing (2)
  • src/main/resources/application-prod.yml
  • src/main/resources/application.yml
💤 Files with no reviewable changes (1)
  • src/main/resources/application.yml

Comment thread src/main/resources/application-prod.yml Outdated

@jihxonx jihxonx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@ji-circle
ji-circle merged commit 7fd1025 into dev May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 직렬화 관련 설정 수정

2 participants