refactor/41 - temp: feign 임시 처리 - #42
Conversation
📝 Walkthrough전체 요약
변경 사항어댑터 프로필 범위 확장
예상 코드 리뷰 난이도🎯 1 (Trivial) | ⏱️ ~2분 제안 검토자
마무리 시
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/michelet/order/infrastructure/adapter/PerfReservationValidationAdapter.java`:
- Line 13: PerfReservationValidationAdapter is annotated with `@Profile`({"perf",
"prod"}) which causes it to override DefaultReservationValidationAdapter in prod
and disable real validation; remove "prod" from the `@Profile` on
PerfReservationValidationAdapter or alternatively make
DefaultReservationValidationAdapter take precedence (e.g. remove its negated
profile, mark it `@Primary` or use `@ConditionalOnMissingBean`) so that in prod the
real validation bean (DefaultReservationValidationAdapter) is registered instead
of the perf stub; locate the annotations on PerfReservationValidationAdapter and
DefaultReservationValidationAdapter and adjust the profiles/bean precedence
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e43b7cfd-cea3-49db-898f-3128eeb156f1
📒 Files selected for processing (1)
src/main/java/com/michelet/order/infrastructure/adapter/PerfReservationValidationAdapter.java
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
릴리스 노트