[Chore] Cd 설정 변경 - #78
Hidden character warning
Conversation
📝 Walkthrough요약이 PR은 예약 서비스의 타임존을 Asia/Seoul로 통일하고 배포 파이프라인을 업데이트합니다. Dockerfile과 application.yaml에서 애플리케이션 타임존을 설정하며, 배포 워크플로우에서 소스 브랜치를 dev로 변경하고 ECS 컨테이너에 데이터베이스, 캐시, 인증 환경변수를 추가합니다. 변경 사항애플리케이션 타임존 및 배포 통합
관련 PR
제안 레이블
제안 리뷰어
리뷰 난이도🎯 2 (Simple) | ⏱️ ~10 분 토끼의 축하 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CD pipeline to deploy to ECS from the dev branch (instead of main), expands the ECS task-definition environment with database/Redis/internal-auth variables, and forces the application timezone to Asia/Seoul across the JVM, Jackson, and the container.
Changes:
- Switch
cd-prod.ymltrigger branch frommaintodevand inject Postgres/Redis/INTERNAL_AUTH_SECRET/TZ env vars into the ECS container definition. - Gate the AWS OIDC credentials step in
ci-prod.ymltopushevents only (consistent with subsequent ECR steps). - Set timezone to
Asia/Seoulvia Dockerfile JVM flag and Spring Jackson config.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/cd-prod.yml |
Trigger on dev branch and add DB/Redis/auth/TZ env vars to ECS task definition |
.github/workflows/ci-prod.yml |
Restrict AWS credentials configuration step to push events |
Dockerfile |
Add -Duser.timezone=Asia/Seoul to JVM entrypoint |
src/main/resources/application.yaml |
Set Jackson time-zone to Asia/Seoul |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cd-prod.yml:
- Around line 75-83: The workflow currently injects sensitive values
(JWT_SECRET, POSTGRES_PASSWORD, INTERNAL_AUTH_SECRET and similar) into the ECS
task definition as plain environment variables via the template arg usage, which
exposes them through DescribeTaskDefinition; change the template so these
secrets are not placed under containerDefinitions[].environment but under
containerDefinitions[].secrets with a valueFrom that references the Secrets
Manager or SSM Parameter Store ARN/secret (use the appropriate ARN for each
secret), and update any places that pass --arg for those secret values to
instead pass ARNs or references that populate containerDefinitions[].secrets
(preserve non-secret envs as environment entries).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 34667113-56bf-49f7-acda-da320e3576cb
📒 Files selected for processing (4)
.github/workflows/cd-prod.yml.github/workflows/ci-prod.ymlDockerfilesrc/main/resources/application.yaml
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
릴리스 노트