[Refactor] status 누락 파트 수정 - #80
Merged
Merged
Conversation
…modification checks
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
There was a problem hiding this comment.
Pull request overview
Reservation 상태 전이/정책 판단 로직을 Reservation 엔티티에서 상태 객체(ReservationState)로 더 이동시켜 책임 분리를 보완하고, 운영 환경 시간대 및 배포 파이프라인 설정을 함께 조정하는 PR입니다.
Changes:
Reservation의 완료/수정 가능 여부 및 체크인 가능 시간 검증을ReservationState/ConfirmedState로 위임- 기존
ReservationTransition(enum) 및 관련 테스트 제거 - Asia/Seoul 시간대 설정 추가 및 CI/CD 워크플로우 구조/환경변수 주입 방식 변경
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/michelet/reservation/domain/state/ReservationState.java | 상태별 정책/검증 메서드 기본 구현 추가(비-CONFIRMED는 false/예외) |
| src/main/java/com/michelet/reservation/domain/state/ConfirmedState.java | 취소/수정 가능, 수정/완료 가능 assert 로직을 CONFIRMED 상태로 이동 |
| src/main/java/com/michelet/reservation/domain/entity/Reservation.java | complete/modify/isCancellable/isModifiable 로직을 상태 객체로 위임 |
| src/main/resources/application.yaml | Jackson 기본 time-zone을 Asia/Seoul로 설정 |
| Dockerfile | JVM 기본 timezone을 Asia/Seoul로 강제 |
| .github/workflows/ci-prod.yml | main 브랜치 기준으로 테스트/빌드푸시 잡 분리 및 권한/조건 정리 |
| .github/workflows/cd-prod.yml | ECS task definition에 TZ 및 DB/Redis/internal auth 관련 env 주입 추가 |
| src/main/java/com/michelet/reservation/domain/enums/ReservationTransition.java | 전이 enum 제거 |
| src/test/java/com/michelet/reservation/domain/enums/ReservationTransitionTest.java | 전이 enum 테스트 제거 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료