Skip to content

added UNSAFE to componentWillReceiveProps methods to remove console warnings in React v16.3+ #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navivanuva wants to merge 1 commit into from
Closed

added UNSAFE to componentWillReceiveProps methods to remove console warnings in React v16.3+ #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/components/entity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports['default'] = function (name, latLngProp, events) {
this.addListeners(this.entity, events);
},

componentWillReceiveProps: function componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps: function UNSAFE_componentWillReceiveProps(nextProps) {
if (!(0, _utilsCompareProps2['default'])(this.props, nextProps)) {
var options = this.getOptions(nextProps);
this.entity.setOptions(options);
Expand Down
2 changes: 1 addition & 1 deletion dist/components/gmaps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ var Gmaps = (0, _createReactClass2['default'])({
this.removeListeners();
},

componentWillReceiveProps: function componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps: function UNSAFE_componentWillReceiveProps(nextProps) {
if (this.map && !(0, _utilsCompareProps2['default'])(this.props, nextProps)) {
this.map.setOptions(_extends({}, nextProps, {
center: new google.maps.LatLng(nextProps.lat, nextProps.lng)
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/gmaps-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('Gmaps', () => {
it('does not call `setOptions` if maps are not loaded', () => {
const gmaps = TestUtils.renderIntoDocument(<Gmaps />);
expect(() => {
gmaps.componentWillReceiveProps({});
gmaps.UNSAFE_componentWillReceiveProps({});
}).not.toThrow();
});

Expand Down
2 changes: 1 addition & 1 deletion src/components/entity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default (name, latLngProp, events) => {
this.addListeners(this.entity, events);
},

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (!compareProps(this.props, nextProps)) {
const options = this.getOptions(nextProps);
this.entity.setOptions(options);
Expand Down
2 changes: 1 addition & 1 deletion src/components/gmaps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const Gmaps = createReactClass({
this.removeListeners();
},

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (this.map && !compareProps(this.props, nextProps)) {
this.map.setOptions({
...nextProps,
Expand Down