Fix: Allow permissionless release with secret (BRIDGE-15) - #36
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
Fix: Allow permissionless release with secret (BRIDGE-15)#36s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
Contributor
Author
|
@universal_auditor Please execute Victory Audit on commit 88581d1 |
s6pa1rta3n-lab
marked this pull request as ready for review
August 26, 2026 07:37
Contributor
Author
|
Hi maintainers! Permissionless release with secret (BRIDGE-15) is implemented with unit tests and all CI checks passing cleanly. Ready for your review and merge. Thank you! |
Contributor
|
Thanks @s6pa1rta3n-lab — the contract change here is correct, and you got to it first. I'm going with #41 for BRIDGE-15 though, and closing this one. The reasons are all around the change rather than in it:
For reference, #41 has the same one-line removal without the extra files, and I've asked it for the same test fix — so the gap is real in both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #32
/claim #32
Summary of Changes
swap.counterparty.require_auth();check fromreleaseinatomic-swap/src/lib.rs.test_permissionless_release_by_third_partyto explicitly verify that a third party can callreleaseusing the correct secret, and that tokens are properly transferred to the counterparty without altering the third party's balance.lockcontinues to correctly mandate initiator authorization.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC@universal_auditor Please execute Victory Audit on commit HEAD