Fix premium-ingress parameter name and default value#128556
Open
simonjj wants to merge 1 commit into
Open
Conversation
Correct the parameter table in the premium ingress documentation: - Rename request-idle-limit to request-idle-timeout to match the actual az CLI flag - Update termination-grace-period default from n/a to 500 (the actual default) Fixes microsoft/azure-container-apps#1634 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
Contributor
|
@simonjj : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 076829d: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the parameter table in the premium ingress documentation, based on the issue reported in microsoft/azure-container-apps#1634.
Verified against the official
az containerapp env premium-ingressCLI reference:request-idle-limittorequest-idle-timeoutto match the actual CLI flag.termination-grace-perioddefault fromn/ato500(the actual CLI default).The
termination-grace-periodmaximum of 3600 was already correct in the current docs.