Feature/vvereen direct lake docs#3057
Conversation
|
Learn Build status updates of commit 0c9ed1c: ✅ Validation status: passed
For more details, please refer to the build report. |
|
|
Learn Build status updates of commit 0c9ed1c: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Hi @vvereen - It looks like you accidentally opened this PR in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you! ** Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
@vvereen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
kgremban
left a comment
There was a problem hiding this comment.
Approved, but some changes suggested to improve formatting and clarity.
Co-authored-by: Kelly Gremban <kgremban@microsoft.com>
Co-authored-by: Kelly Gremban <kgremban@microsoft.com>
Co-authored-by: Kelly Gremban <kgremban@microsoft.com>
|
Learn Build status updates of commit 746bba2: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit fd87e1b: ✅ Validation status: passed
For more details, please refer to the build report. |
| > If possible, you should always design your solution—or size your capacity—to avoid DirectQuery fallback. That's because it might result in slower query performance. | ||
|
|
||
| You can control fallback of your Direct Lake semantic models by setting its _DirectLakeBehavior_ property. This setting only applies to Direct Lake on SQL endpoints. Direct Lake on OneLake doesn't support DirectQuery fallback. For more information, see [Model.DirectLakeBehavior Property](/dotnet/api/microsoft.analysisservices.tabular.model.directlakebehavior). | ||
| Direct Lake on OneLake does not support DirectQuery fallback and operates only in DirectLakeOnly mode. If you need to avoid fallback entirely, consider using Direct Lake on OneLake. Direct Lake on Onelake is the recommended Direct Lake flavor for new semantic model applications. |
There was a problem hiding this comment.
If you need to avoid fallback entirely, consider using Direct Lake on OneLake.
a bit weird sentence if i am being honest, best if we remove it entirely, in this case less is more :)
| - Number of row groups is within limit | ||
| - Number of rows is within limit | ||
| - The semantic model has been refreshed (framed) since the underlying Delta tables were created or modified. | ||
| - The capacity is not under memory pressure. |
There was a problem hiding this comment.
I can remove rows 100 & 101, are the rest are still accurate? Apologies pulled these two from community blog posts.
|
|
||
| Queries use Direct Lake mode only when *all* of the following conditions are satisfied: | ||
|
|
||
| - No tables referenced by the semantic model have SQL [row-level security (RLS)](direct-lake-security-integration.md) defined at the SQL analytics endpoint. |
There was a problem hiding this comment.
those are conditions for using VertiPlans in DirectLake SQL.. it miscommunicates things to customers.
There was a problem hiding this comment.
Would naming the section "Conditions for avoiding DirectQuery fallback" be better?
@v-regandowner, @kgremban Apologies, I have not used this process before but will ensure to use the Private Repo next time. As there are changes needed and potential new ownership, would it be best if we close and reopen on the Private Repo? |
@vvereen It'd be best to have these moved to private so the content can be staged and validated by the current validation rules. After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged. cc: @kgremban |
Removed and renamed 2 things based on comments
|
Learn Build status updates of commit bb38f83: ✅ Validation status: passed
For more details, please refer to the build report. |
Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.
Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.
For internal Microsoft contributors, check off these quality control items as you go
1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.
2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).
3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.
4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.
5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing
#sign-offin a new comment in the Pull Request. If you need to cancel that sign-off, type#hold-offinstead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.Merge and publish
#sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.#sign-offagain. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).