Skip to content

Conversation

@fuguiKz
Copy link

@fuguiKz fuguiKz commented Dec 28, 2025

Clarifies MSBuild UsingTask Runtime metadata docs.

  • docs/msbuild/usingtask-element-msbuild.md: removes duplicated/ambiguous wording and documents Runtime="NET" (MSBuild 18.0+) plus the current limitation (only supported for Microsoft.NET.Sdk projects today).
  • docs/msbuild/how-to-configure-targets-and-tasks.md: aligns TaskHost wording and updates the conditional sample to use $(MSBuildVersion).

Refs dotnet/msbuild#12905.

@prmerger-automator
Copy link
Contributor

@fuguiKz : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7ba5f31:

✅ Validation status: passed

File Status Preview URL Details
docs/msbuild/how-to-configure-targets-and-tasks.md ✅Succeeded
docs/msbuild/usingtask-element-msbuild.md ✅Succeeded

For more details, please refer to the build report.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the MSBuild UsingTask element's Runtime attribute documentation, specifically documenting the new Runtime="NET" support introduced in MSBuild 18.0 (.NET SDK 10/Visual Studio 2026).

Key changes:

  • Improved clarity of Runtime attribute documentation by removing duplicated/ambiguous wording
  • Documented Runtime="NET" support and its current limitation (only works with Microsoft.NET.Sdk projects)
  • Updated code examples to use $(MSBuildVersion) instead of $(SdkAnalysisLevel) for more accurate version checking

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/msbuild/usingtask-element-msbuild.md Clarified the Runtime attribute description, documented Runtime="NET" support and limitations, and improved overall readability
docs/msbuild/how-to-configure-targets-and-tasks.md Aligned TaskHost terminology (tasks→tasks, process→processes), updated warning message for consistency, and improved conditional UsingTask example to use $(MSBuildVersion) for version checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@v-regandowner
Copy link
Contributor

@ghogen

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants