Skip to content

Add missing shell directive to PowerShell build steps#27

Closed
Mika3578 with Copilot wants to merge 2 commits into
vs2022from
copilot/sub-pr-23
Closed

Add missing shell directive to PowerShell build steps#27
Mika3578 with Copilot wants to merge 2 commits into
vs2022from
copilot/sub-pr-23

Conversation

Copilot AI commented Nov 12, 2025

Copy link
Copy Markdown

Addresses feedback from #23 regarding missing shell: pwsh directives in build steps using PowerShell syntax.

Changes

  • Added explicit shell: pwsh to "Build Solution" step (line 87)
  • Added explicit shell: pwsh to "Build Debug Configuration" step (line 193)

Both steps use PowerShell-specific syntax (Join-Path, $variable, backtick continuation) but were relying on implicit shell selection, which could cause inconsistent behavior across different runner configurations.

- name: Build Debug Configuration
  working-directory: ${{ github.workspace }}
  shell: pwsh  # ← Added
  run: |
    $outDir = Join-Path "${{ env.BUILD_OUTPUT_ROOT }}" "${{ matrix.platform }}\Debug\Binary\"
    msbuild /m `
      /p:Configuration=Debug `
      ...

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Mika3578 <58137747+Mika3578@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Vs2022 pull request Add missing shell directive to PowerShell build steps Nov 12, 2025
@Mika3578 Mika3578 closed this Nov 12, 2025
@Mika3578
Mika3578 deleted the copilot/sub-pr-23 branch November 12, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants