Skip to content

Sweep the change set, not only the file you noticed the defect in #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeGrier merged 1 commit into from
Sep 14, 2026
Merged

Sweep the change set, not only the file you noticed the defect in #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,6 +1254,10 @@ files, 4 updated, 9 incidental mentions"). Do **not** fix only the site a review
the reported site is a sample, not the population. This is cheap and it works: run once
voluntarily on this repository, a sweep immediately found a stale site no reviewer had reported.

**And sweep the change set, not only the file you noticed it in:** when you fix a defect of any
kind in one file of a commit, grep the commit's other files for the same defect before committing
-- the file you happened to be reading is a sample of your own change too.

Two corollaries that have each already cost a review round:

- **An analysis document never restates normative content.** An audit, review response, or design
Expand Down