Isolate persistent sessions by workspace folder - #3
Draft
nickadminroot wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persisterm.sessionPrefixvalues exactly, including their existing sessions<prefix>-Nsession names so global and workspace sessions cannot mixStack
This PR is stacked on #2. The workspace-isolation changes are the commits above
930ed4d. After #2 merges, this branch can be rebased onto the updatedmasterif GitHub does not reduce the diff automatically.Verification
npm test(12 tests pass)npm run lintnpm run compilenpm run package -- --out persisterm-workspace-isolation.vsix