chore(ruff): exclude plc/ignition-project from CPython linting#2376
chore(ruff): exclude plc/ignition-project from CPython linting#2376Mikecranesync wants to merge 2 commits into
Conversation
These are Ignition Jython 2.7 scripts that use java.io.* imports and system.* gateway-injected globals. They fail F821/I001 when linted by ruff as if they were CPython — same reason the existing exclusions for ignition/webdev and ignition/gateway-scripts exist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SET9q6YugGG8LNdHJxFpB1
🤖 AI Code ReviewReview by: groq (llama-3.3-70b-versatile) Review of PR🔴 IMPORTANT: Security vulnerabilitiesNo security vulnerabilities were found in this diff. 🔴 IMPORTANT: Missing error handling on network/IO operationsNo network/IO operations were found in this diff, so no error handling issues were identified. 🟡 WARNING: Logic bugs or incorrect assumptionsNo logic bugs or incorrect assumptions were found in this diff. The exclusion of 🟡 WARNING: Missing input validation at API boundariesNo API boundaries were modified in this diff, so no input validation issues were identified. 🔵 SUGGESTION: Code quality improvements, naming, maintainabilityThe code change is concise and well-structured. However, it would be beneficial to include a comment explaining why # Exclude plc/ignition-project as it requires custom Jython environment for linting
"plc/ignition-project",This would improve the maintainability of the code by providing context for future developers. ✅ GOOD: Noteworthy good practices foundThe use of a configuration file ( Generated by the MIRA automated code review pipeline (Groq → Cerebras → Gemini cascade) |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SET9q6YugGG8LNdHJxFpB1
MIRA staging gate — ✅ PASSEngine + NeonDB staging branch + Groq cascade against fixed questions, graded on the 5-dimension rubric in
Rubric: |
🤖 AI Code ReviewReview by: groq (llama-3.3-70b-versatile) Review of Pull Request🔴 IMPORTANT: Security vulnerabilitiesNo security vulnerabilities were found in the provided diff. 🔴 IMPORTANT: Missing error handling on network/IO operationsNo network/IO operations were found in the provided diff. 🟡 WARNING: Logic bugs or incorrect assumptionsNo logic bugs or incorrect assumptions were found in the provided diff. 🟡 WARNING: Missing input validation at API boundariesNo API boundaries were found in the provided diff. 🔵 SUGGESTION: Code quality improvements, naming, maintainabilityThe addition of ✅ GOOD: Noteworthy good practices foundThe use of a consistent formatting style and the adherence to the existing structure in Generated by the MIRA automated code review pipeline (Groq → Cerebras → Gemini cascade) |
Summary
plc/ignition-projectto the ruffexcludelist inpyproject.tomlThese are Ignition Jython 2.7 scripts (
mira_chat,mira_diagnose,mira_setup, etc.) that landed in recent commits (feat(seed) #2362, feat(cloud-wiring) #2370). They usejava.io.*imports and the Ignition gateway-injectedsystem.*global, which ruff correctly flags asF821(undefined name) andI001(import sort) when treated as CPython. The existing exclusions forignition/webdevandignition/gateway-scriptsexist for the same reason — this extends the same pattern to the Northwind Bottling project scripts.Found by the daily stop-gate when ruff was run against the files changed in HEAD~5..HEAD.
Test plan
ruff check --force-exclude plc/ignition-project/NorthwindBottling/ignition/script-python/mira_chat/code.py→ exits 0ruff check .passes on this branchGenerated by Claude Code