Skip to content

Revert "Feat/milestone3 part 1 infrastructure bridge"#7

Merged
MiltonJ23 merged 1 commit intomainfrom
revert-5-feat/milestone3-part-1-infrastructure-bridge
Apr 14, 2026
Merged

Revert "Feat/milestone3 part 1 infrastructure bridge"#7
MiltonJ23 merged 1 commit intomainfrom
revert-5-feat/milestone3-part-1-infrastructure-bridge

Conversation

@MiltonJ23
Copy link
Copy Markdown
Owner

@MiltonJ23 MiltonJ23 commented Apr 14, 2026

Reverts #5

Summary by CodeRabbit

  • New Features

    • Migrated to container-focused build and deployment via GitHub Container Registry.
  • Bug Fixes

    • Simplified error handling for improved consistency.
  • Documentation

    • Completely redesigned README with updated branding, architecture overview, and streamlined Getting Started guide.
  • Chores

    • Removed OpenAI dependency.
    • Removed Kubernetes deployment manifest.
    • Removed agent orchestration and related services.
    • Updated Docker base images and simplified build process.
    • Database schema cleanup.

@MiltonJ23 MiltonJ23 merged commit 11bfbf3 into main Apr 14, 2026
0 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8071d928-22d4-4309-96e8-4e2cd662ac71

📥 Commits

Reviewing files that changed from the base of the PR and between 3c0cc28 and 1359d4f.

⛔ Files ignored due to path filters (2)
  • Architecture_Kliops.png is excluded by !**/*.png
  • coverage.out is excluded by !**/*.out
📒 Files selected for processing (23)
  • .dockerignore
  • .github/workflows/ci.yml
  • .github/workflows/deploy.yml
  • .github/workflows/release.yml
  • Dockerfile
  • README.md
  • cmd/kliops-api/main.go
  • cmd/kliops-api/main_test.go
  • deployments/k8s/kliops.yaml
  • deployments/migrations/20260405103115-init_knowledge_base.sql
  • go.mod
  • internal/adapters/agent/multi_agent.go
  • internal/adapters/handlers/agent_handler.go
  • internal/adapters/handlers/agent_handler_test.go
  • internal/adapters/handlers/gateway.go
  • internal/adapters/handlers/middleware_test.go
  • internal/adapters/queue/rabbitmq.go
  • internal/core/services/agent_service.go
  • internal/core/services/agent_service_test.go
  • internal/core/services/archive_service.go
  • internal/core/services/document_service.go
  • internal/core/services/knowledge_service.go
  • internal/core/services/pricing_service_test.go

📝 Walkthrough

Walkthrough

This PR removes agent/orchestrator functionality (multi-agent systems, agent handlers, and related services), deletes Kubernetes and release workflows, simplifies application bootstrap to initialize only MinIO/PostgreSQL/RabbitMQ, eliminates knowledge-base vector search, and refactors Docker/CI configuration for containerized builds.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Consolidation
.github/workflows/ci.yml, .github/workflows/deploy.yml, .github/workflows/release.yml
Removed manual deployment and release workflows (deploy.yml, release.yml); renamed and refactored ci.yml from test-and-build to build-and-push, removing Go-specific steps (vet, race tests, coverage artifacts, binary build) and replacing with containerized Docker build-push-action to GHCR with SHA/latest tags on main branch pushes.
Docker Configuration
Dockerfile, .dockerignore
Removed .dockerignore entirely; updated Dockerfile base images (golang:1.25.3-alpinegolang:1.25-alpine, alpine:3.22alpine:3.21), consolidated package installation into single RUN steps, removed VERSION build argument and linker flags, removed dummy_prices.xlsx copy and environment variables (APP_ADDR, PRICING_EXCEL_PATH), moved binary to /usr/local/bin/kliops-api with entrypoint name-based invocation.
Application Bootstrap
cmd/kliops-api/main.go, cmd/kliops-api/main_test.go
Drastically simplified bootstrap: removed Qdrant/Ollama/Google Workspace/worker initialization and replaced multi-service orchestration with MinIO/PostgreSQL/RabbitMQ only; stripped routes to /health and /api/v1/ gateway/ingestion endpoints; added HealthResponse struct; removed test file entirely.
API Handlers Refactoring
internal/adapters/handlers/agent_handler.go, internal/adapters/handlers/agent_handler_test.go, internal/adapters/handlers/gateway.go, internal/adapters/handlers/middleware_test.go
Deleted agent handler and its tests (POST /api/v1/agent/ask endpoint removed); simplified gateway HandlePrice error handling from 404-on-no-rows to generic 500; minor formatting cleanup in middleware tests.
Service Layer Removals
internal/core/services/agent_service.go, internal/core/services/agent_service_test.go, internal/core/services/knowledge_service.go
Completely removed AgentService (request validation, LLM prompt orchestration), AgentOrchestrator interface, domain types (TenderRequest, TenderResponse), sentinel errors, and KnowledgeService (vector search and methodology retrieval).
Service Layer Updates
internal/core/services/archive_service.go, internal/core/services/document_service.go
Removed MEMOIRE document upload-and-save from ProcessZipArchive (only DCE persisted); inlined storage constants in CompileTechnicalMemory, refactored error messages and template stream handling, preserved overall control flow.
Kubernetes Deployment
deployments/k8s/kliops.yaml
Removed entire manifest: Namespace, ConfigMap, Secrets, Deployment (2 replicas), Service, and NGINX Ingress for kliops.example.com.
Infrastructure & Dependencies
internal/adapters/queue/rabbitmq.go, deployments/migrations/20260405103115-init_knowledge_base.sql, go.mod
Whitespace-only formatting in RabbitMQ adapter (no logic change); removed mercuriale table from migrations; dropped go-openai dependency.
Testing & Code Quality
internal/core/services/pricing_service_test.go
Removed concurrency test and duplicate test cases, keeping equivalent coverage via newer test set; minor formatting updates.
Documentation
README.md
Rewrote entire README: replaced ASCII architecture diagram with badge/branding, condensed sections, simplified Getting Started to quick-start steps, added higher-level API endpoint list, pointed to Wiki/OpenAPI docs for details, updated License to AGPL v3.0, removed extensive configuration/schema/testing documentation.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • PR #3: Removes ingestion/agent/worker surface that was previously implemented; directly inverse relationship with architectural scope.
  • PR #4: Both PRs modify cmd/kliops-api/main.go bootstrap and service wiring patterns in opposing directions.
  • PR #5: Opposite changes to .dockerignore (this PR removes it; related PR adds it).

Poem

🐰 The agent's leap was bold and grand,
But simpler paths demand the land—
Qdrant and Ollama take their bow,
With Docker's push and K8s now,
We hopped back down to MinIO's row. 🚀

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-5-feat/milestone3-part-1-infrastructure-bridge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant