fix(#368): position section content with absolute coords to fix Safari icon placement - #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<g transform="translate(…)">insrc/section.tsand foldsection.offsetinto the cross-axis ofcolorRect,labelArea, and connector edges (nearEdge/midEdge/farEdge).<g transform>and rendered icons via<foreignObject>containingha-icon. On WebKit (Safari, iOS), the nested<svg>insideha-iconignores ancestor SVG transforms, so icons paint at the chart's origin — clustered in a row at the top in vertical mode and a column on the left in horizontal mode. Plain HTML label content isn't affected by the same code path, which is why labels look correct in the screenshots while icons don't.x/yagainst the root SVG, so there's no ancestor transform for WebKit to mis-resolve. Visual output is unchanged on Chrome/Firefox.Fixes #368. Likely also fixes #367.
Test plan
npm run lint— clean (pre-existing warnings only)npm test— 95/95 pass after regenerating the two affected snapshotsnpm run build— succeeds