add engineering team to generated projects#2
Merged
MauricioGuevaraNice merged 3 commits intodotnet8_minimal_awssdkfrom Feb 25, 2026
Merged
add engineering team to generated projects#2MauricioGuevaraNice merged 3 commits intodotnet8_minimal_awssdkfrom
MauricioGuevaraNice merged 3 commits intodotnet8_minimal_awssdkfrom
Conversation
|
|
||
| // Get all teams | ||
| var httpResponse = await HttpClient.SendAsync(new HttpRequestMessage { | ||
| RequestUri = new Uri($"https://api.rollbar.com/api/1/teams?access_token={_accountReadAccessToken}"), |
There was a problem hiding this comment.
are we sure the acces token goes in the header? seems like it would be an authorization header
There was a problem hiding this comment.
also, is there limit we need worry about here? like limit=100
Author
There was a problem hiding this comment.
I saw that the limit for Rollbar is 30, I think 100 is enough
Author
There was a problem hiding this comment.
and also I changed to hedaer
| LogInfo($"assigning rollbar project {projectId} to team '{ENGINEERING_TEAM_NAME}' (ID: {teamId})"); | ||
|
|
||
| httpResponse = await HttpClient.SendAsync(new HttpRequestMessage { | ||
| RequestUri = new Uri($"https://api.rollbar.com/api/1/team/{teamId}/project/{projectId}?access_token={_accountWriteAccessToken}"), |
Scripts/Set-Lash-Version.ps1
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Set variables | |||
| $env:LAMBDASHARP_VERSION_PREFIX = "0.8.5" | |||
| $env:LAMBDASHARP_VERSION_PREFIX = "0.8.6" | |||
Author
There was a problem hiding this comment.
as we talk we are doing this to have a safe transition to a new version
MauricioGuevaraNice
force-pushed
the
add-team-to-rollbar-project
branch
from
0ec3198 to
342625e
Compare
skittleson
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add "Engineering" team to deployed projects