feat(cms): about page migration to payload#138
Draft
novruzoff wants to merge 14 commits into
Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 0e6725d in 2 minutes and 6 seconds
More details
- Looked at
379lines of code in5files - Skipped
0files when reviewing. - Skipped posting
9drafted comments based on config settings.
1. src/app/(app)/(pages)/about/page.tsx:63
- Draft comment:
Consider extracting the Payload client to a variable to avoid double-await, which improves readability. - Reason this comment was not posted:
Confidence changes required:66%<= threshold70%
None
2. src/app/(app)/(pages)/about/page.tsx:111
- Draft comment:
Avoid casting 'page' as 'any' for SEO; consider a safer type guard or default value structure. - Reason this comment was not posted:
Confidence changes required:66%<= threshold70%
None
3. src/globals/AboutPage.ts:31
- Draft comment:
Update of 'update' access from 'denyAccessField' to 'canEditContent' should be reviewed to ensure permission requirements are met. - Reason this comment was not posted:
Confidence changes required:66%<= threshold70%
None
4. src/globals/AboutPage.ts:40
- Draft comment:
Changing groupPhoto from required to optional is a design decision; double-check that this aligns with content requirements. - Reason this comment was not posted:
Confidence changes required:66%<= threshold70%
None
5. src/payload-types.ts:759
- Draft comment:
The updated type for groupPhoto now allows null; ensure this matches the API responses and frontend handling. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold70%
The comment is asking the author to ensure that the change matches the API responses and frontend handling, which is against the rules. It doesn't provide a specific suggestion or ask for a specific test to be written.
6. src/app/(app)/(pages)/about/page.tsx:100
- Draft comment:
Consider using a unique identifier rather than the array index for the key in the team sections mapping. - Reason this comment was not posted:
Comment was on unchanged code.
7. src/app/(app)/(pages)/about/page.tsx:110
- Draft comment:
Avoid using an 'as any' cast in generateMetadata; consider proper typing for the 'page' object for better type safety. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 70%
The 'as any' cast here is actually a deliberate choice with documented reasoning. Creating proper typing would require modifying the global schema or creating a separate interface just for this optional property. Given that there's a fallback value, the current approach is pragmatic and well-documented. The comment seems to be suggesting a "best practice" without considering the specific context.
Perhaps there could be a more type-safe way to handle this, like extending the AboutContent interface or using a union type.
While type safety is important, the current solution is intentional, documented, and handles an edge case appropriately without adding unnecessary complexity.
Delete the comment. The use of 'as any' is intentional, documented, and serves a specific purpose in handling an optional property with a fallback value.
8. src/globals/AboutPage.ts:65
- Draft comment:
There appears to be a redundant '//' in the comment on line 65 (i.e., "// // From requested changes: fr support added"). Consider removing one of the slashes for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. src/globals/AboutPage.ts:77
- Draft comment:
The language labels for content fields are inconsistent in their casing. For example, 'Page Title (EN)' uses uppercase whereas 'Introduction - En' (line 77) and 'Initiative Details - En' (line 96) use 'En' instead of 'EN'. Similarly, 'Introduction - Fr' (line 87) and 'Initiative Details - Fr' (line 106) should be 'FR' for consistency. Consider standardizing these labels for improved consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_YmDOaRIbCofJIjSx
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| /* Hero image styling */ | ||
| .heroImage { | ||
| @apply h-full w-full object-cover brightness-90 transition-transform duration-500 group-hover:scale-105 group-hover:brightness-100; |
Contributor
There was a problem hiding this comment.
The .heroImage class uses group-hover utilities. Ensure the parent (e.g., .heroImageWrapper) has a 'group' class if the hover effects are intended.
55e1b06 to
0a4861f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 9a0eba7.
a956532 to
81da645
Compare
|
Commit messages do not follow conventional commit guidelines. Please see https://github.com/MindVista/website/wiki/Commit-Guidelines for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Migrates the 'About' page to Payload CMS, updating data models, database schema, and frontend components to fetch and display data from the CMS.
getPayloadClient()inpage.tsx.groupPhotois missing.TeamSectioncomponent inpage.tsx.TeamSection.tsx.AboutPageglobal config inAboutPage.ts.20250228_031847_payload_about.tsand20250228_031847_payload_about.jsonfor new tables and enums.AboutandAboutSelectinterfaces inpayload-types.ts.AboutPageinpayload.config.ts.This description was created by
for 2ca5fb0. It will automatically update as commits are pushed.