chore(deps): bump react-native from 0.80.1 to 0.83.1 in /demo #209
Conversation
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/demo/react-native-0.83.1
branch
2 times, most recently
from
1c3617e to
12dc2dd
Compare
Bumps [react-native](https://github.com/facebook/react-native/tree/HEAD/packages/react-native) from 0.80.1 to 0.83.1. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react-native/commits/v0.83.1/packages/react-native) --- updated-dependencies: - dependency-name: react-native dependency-version: 0.83.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/demo/react-native-0.83.1
branch
from
12dc2dd to
93304aa
Compare
…tch requirements of modern gradle.
TheRealAgentK
requested review from
Copilot,
miquelbeltran and
velocitysystems
There was a problem hiding this comment.
Pull request overview
This PR upgrades React Native from version 0.80.1 to 0.83.1 in the demo application, bringing critical bug fixes and new features while updating the Android build infrastructure to support modern tooling requirements.
Key changes:
- React Native core and related packages upgraded to 0.83.1
- Android build tools modernized (Gradle 8.x, AGP 8.12.0, SDK 35)
- Build configuration refactored for compatibility with React Native 0.83+ architecture
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| demo/package.json | Updates React Native to 0.83.1 and related tooling packages |
| demo/android/build.gradle | Modernizes build script with updated SDK versions and plugin syntax |
| demo/android/gradle.properties | Adds JDK auto-provisioning configuration |
| demo/android/settings.gradle | Restructures plugin management with explicit repository configuration |
| demo/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to version 8.13 |
| sdk/android/build.gradle | Major refactor for AGP 8.x compatibility with updated SDK targets and dependency versions |
| sdk/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.2 with enhanced security |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
@TheRealAgentK Good work tackling this dependency upgrade. A few thoughts:
The demo app changes look fine, but I'm curious about the SDK changes. The SDK's build.gradle should ideally be as permissive as possible since it's consumed by host apps that control their own build environment.
Changes required for RN 0.83 / AGP 8.x compatibility:
- namespace "com.raygun.react" — required for AGP 8.x
- react-android artifact (was react-native) — required for RN 0.71+
Changes to investigate further:
DEFAULT_MIN_SDK_VERSION19 → 24 — Is this required by RN 0.83, or just aligning with the demo app? (If required, that's fine - just want to confirm)DEFAULT_COMPILE_SDK_VERSION28 → 35 — Host apps typically override this anyway- Removing the standalone buildscript block — Intentional?
- Timber 4.7.1 → 5.0.1 — Any API changes to be aware of?
- SDK's Gradle wrapper 7.6.3 → 8.14.2 — Host app typically controls this
Should we keep the SDK changes minimal (just the required compatibility fixes) and leave defaults conservative where possible? Or if these are all genuinely required for RN 0.83 compatibility, should we document them as breaking changes?
| apply plugin: 'com.android.library' | ||
| apply plugin: 'maven-publish' | ||
|
|
||
| buildscript { |
There was a problem hiding this comment.
This removes the ability to build the SDK standalone. Is this intentional?
There was a problem hiding this comment.
See big comment thread.
I reverted this for now back to 19 because it seems the sdk builds ok with it. Note - as discussed on Slack, we will need to update RG4Android that's bundled and that will push up min sdk to 23 anyway soon. But for now we can stick with 19.
I think that's fine because we need to make sure we go with updated tooling. I'm not 100% certain how exactly the build flow of a RN works in depth - happy to get more input from you, but I'd usually keep this as up-to-date as possible in Android-land.
No, not really. What exactly would fail or not work anymore without this? Just curious - because it seems I can build the sdk itself fine.
I reverted this - will have to be updated to 5.0.1 though with the future RG4Android upgrade.
I've reverted some that I think are fine. @velocitysystems @miquelbeltran happy to take more feedback and more specific build flow know-how for RN specifically into consideration. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/demo/react-native-0.83.1
branch
Bumps react-native from 0.80.1 to 0.83.1.
Release notes
Sourced from react-native's releases.
... (truncated)
Changelog
Sourced from react-native's changelog.
... (truncated)
Commits
541213eRelease 0.83.13d78f07Gate requestBody processing behind BuildConfig.DEBUG (#54920)471ef72Fix binary FormData uploads on Android (#54917)a98aa81Release 0.83.0015b567Release 0.83.0-rc.58a9a359Fix multipart/form-data request payload previews on Android (#54804)75f4c83Fix remaining missing debugger build flags for open source builds (#54770)30cbe97Exclude legacy Hermes targets from single host assertion (#54790)c8dd7d4Release 0.83.0-rc.445281baFix 'hermes-compiler' not being resolved correctly (#54667)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)