feat(config): document paired per-network SAC and NFT watch-list env vars (#162) - #174
Open
kaylachi wants to merge 1 commit into
Open
feat(config): document paired per-network SAC and NFT watch-list env vars (#162)#174kaylachi wants to merge 1 commit into
kaylachi wants to merge 1 commit into
Conversation
|
@kaylachi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
Summary of Changes
Adds documentation and verification for paired per-network SAC and NFT watch-list environment variables (
SAC_CONTRACT_IDS_TESTNET,SAC_CONTRACT_IDS_MAINNET,NFT_CONTRACT_IDS_TESTNET,NFT_CONTRACT_IDS_MAINNET), enabling dual-network and single-network deployments to configure distinct watch-lists per chain with backwards-compatible single-variable and per-network default fallbacks.Key Changes
Configuration & Documentation (
.env.example):SAC_CONTRACT_IDS_TESTNETandSAC_CONTRACT_IDS_MAINNETwith native XLM SAC defaults for testnet and mainnet.NFT_CONTRACT_IDS_TESTNETandNFT_CONTRACT_IDS_MAINNETfor explicit CAP-46 NFT tracking per network.Resolution Logic & Fallback Order (
src/indexer.ts):resolveSacContractIds(network): ResolvesSAC_CONTRACT_IDS_${NETWORK}->SAC_CONTRACT_IDS-> legacyCONTRACT_IDS-> network default native XLM SAC (DEFAULT_XLM_SAC_MAINNET/DEFAULT_XLM_SAC_TESTNET).resolveNftContractIds(network): ResolvesNFT_CONTRACT_IDS_${NETWORK}->NFT_CONTRACT_IDS-> empty array.Test Suite (
src/__tests__/multiNetworkIndexer.test.ts):Verification Status
npm test: All 13 test suites and 124 unit tests passing cleanly.kaylachi.kaylachi <309505611+kaylachi@users.noreply.github.com>.