Fix: aggressively close stream on invalid headers to prevent potentia…#134
Open
Paradoks-Studio wants to merge 1 commit intoMirrorNetworking:masterfrom
Open
Fix: aggressively close stream on invalid headers to prevent potentia…#134Paradoks-Studio wants to merge 1 commit intoMirrorNetworking:masterfrom
Paradoks-Studio wants to merge 1 commit intoMirrorNetworking:masterfrom
Conversation
…l attacks I was recently targeted by malformed connection attempts sending invalid headers (e.g., "GET "). By aggressively closing the stream immediately inside ReadMessageBlocking when detecting suspicious headers, I reduced server instability and prevented further abuse. This early shutdown avoids leaving the connection open even for a moment longer, mitigating the risk of buffer abuse or resource exhaustion. It worked for me at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l attacks
I was recently targeted by malformed connection attempts sending invalid headers (e.g., "GET "). By aggressively closing the stream immediately inside ReadMessageBlocking when detecting suspicious headers, I reduced server instability and prevented further abuse. This early shutdown avoids leaving the connection open even for a moment longer, mitigating the risk of buffer abuse or resource exhaustion. It worked for me at least.