Redesign quota rows as a minimal two-window list - #61
Merged
Merged
Conversation
The popover row showed one bar for two windows, so the 7-day figure had no visual weight and neither window said when it resets. Each window now gets its own aligned line (label, bar, percent) plus a small caption with the reset wall clock and the time left. Card chrome is dropped so providers read as one quiet list, and hierarchy comes from bar height and percent weight rather than extra words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popover row showed one bar for two windows, so the 7-day figure had no visual weight and neither window said when it resets.
Each window now gets its own aligned line (label, bar, percent) plus a small caption with the reset wall clock and the time left. Card chrome is dropped so providers read as one quiet list, and hierarchy comes from bar height and percent weight rather than extra words.
quotaRowrenders provider mark + name, then a 5h and a 7d lineResetFormat.resetClockformats the reset stamp (today21:40, this weekSun 12:00, later6-29 12:00)ResetFormat.coarsetrims multi-day countdowns to3dprogressBartakes an optional height so the 7d bar reads as subordinateLocal SwiftPM is broken on this machine (no Xcode; the manifest fails to link PackageDescription), so verification here was
swiftc -parseonly. CI must confirmswift buildandswift test, particularlyPopoverHeightBudgetTestssince each provider row changes height.