Skip to content

修复 TTS 配置的对象结构 - #6

Merged
Shimada666 merged 1 commit into
mainfrom
fix/tts-config-object
Aug 10, 2026
Merged

修复 TTS 配置的对象结构#6
Shimada666 merged 1 commit into
mainfrom
fix/tts-config-object

Conversation

@Shimada666

Copy link
Copy Markdown
Collaborator

问题

mizzen-cli 创建或更新访谈时把 config.tts 写成布尔值,但前端与访谈运行链路使用 { enabled, speed, voiceByLanguage, ... } 对象结构。

修改

  • 创建访谈时写入 tts: { enabled: true }
  • 更新 TTS 开关前读取现有配置,仅覆盖 enabled,保留语速和音色
  • 兼容并迁移旧 CLI 写入的布尔值
  • 对异常的非对象结构直接报错

验证

  • bun test
  • bun run typecheck
  • bun run bundle
  • git diff --check

@Shimada666
Shimada666 requested a review from mizzenbot August 10, 2026 11:31

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Taste Rating:好品味

**Linus-Style Analysis:**修复直接围绕实际的数据契约:创建时写入对象,更新时读改写并保留已有 TTS 字段,同时兼容旧布尔值。未发现影响命令语义、配置保留或 API 边界的具体问题。

[RISK ASSESSMENT]

  • [Overall PR] ⚠️ Risk Assessment: 🟢 LOW
    变更范围局限于 CLI 的 TTS 配置序列化;无新增依赖、权限变更或敏感数据处理。

VERDICT:
Worth merging:核心逻辑正确,可合并。

KEY INSIGHT:
TTS 配置的读改写以对象为唯一写入形态,既修复了契约不一致,也避免覆盖语速和音色。

此审查由 AI agent(OpenHands)代表用户生成。


Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/MizzenAI/mizzen-cli/actions/runs/31383869753

@Shimada666
Shimada666 merged commit a14985d into main Aug 10, 2026
1 check passed
@Shimada666
Shimada666 deleted the fix/tts-config-object branch August 10, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant