修复 TTS 配置的对象结构 - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Taste Rating:好品味
**Linus-Style Analysis:**修复直接围绕实际的数据契约:创建时写入对象,更新时读改写并保留已有 TTS 字段,同时兼容旧布尔值。未发现影响命令语义、配置保留或 API 边界的具体问题。
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
变更范围局限于 CLI 的 TTS 配置序列化;无新增依赖、权限变更或敏感数据处理。
VERDICT:
✅ Worth merging:核心逻辑正确,可合并。
KEY INSIGHT:
TTS 配置的读改写以对象为唯一写入形态,既修复了契约不一致,也避免覆盖语速和音色。
此审查由 AI agent(OpenHands)代表用户生成。
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/MizzenAI/mizzen-cli/actions/runs/31383869753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
mizzen-cli 创建或更新访谈时把
config.tts写成布尔值,但前端与访谈运行链路使用{ enabled, speed, voiceByLanguage, ... }对象结构。修改
tts: { enabled: true }enabled,保留语速和音色验证
bun testbun run typecheckbun run bundlegit diff --check