fix: order sidebar local and cloud projects by activity#673
Merged
Conversation
Local and cloud workspaces are fetched separately and were rendered as two fixed sections, so a fresh cloud chat could not move its project above stale local projects. Merge both into one list sorted by last_chat_at, and invalidate cloud workspaces on new cloud chat so the re-sort happens immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_chat_at, falling back toupdated_at), so a fresh cloud chat can move its project above stale local projects. Previously the two were rendered as fixed sections and could never interleave.sharedGroupPropsto remove duplication between the local and cloud group renders.This re-attempts the work reverted in #672 (revert of #671), now with local + cloud ordering unified so the re-sort is actually reflected.
Test plan