Skip to content

Fix stboxFromHexWKB reading past the input buffer (#170) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estebanzimanyi merged 1 commit into from
Jul 29, 2026
Merged

Fix stboxFromHexWKB reading past the input buffer (#170) #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/geo/stbox_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,12 @@ void StboxFunctions::Stbox_from_hexwkb(DataChunk &args, ExpressionState &state,
UnaryExecutor::Execute<string_t, string_t>(
args.data[0], result, args.size(),
[&](string_t input_hexwkb) -> string_t {
char *hexwkb = (char*)input_hexwkb.GetData();
STBox *stbox = stbox_from_hexwkb(hexwkb);
// string_t::GetData() is not NUL-terminated, but stbox_from_hexwkb()
// strlen()s its argument; reading the raw pointer overruns the buffer
// on allocators that leave the trailing byte non-zero (e.g. macOS arm64).
// Copy into a NUL-terminated std::string first, as the sibling consumers do.
std::string hexwkb = input_hexwkb.GetString();
STBox *stbox = stbox_from_hexwkb(hexwkb.c_str());
if (!stbox) {
throw InternalException("Failure in Stbox_from_hexwkb: unable to cast hexwkb to stbox");
return string_t();
Expand Down
Loading