-
Notifications
You must be signed in to change notification settings - Fork 291
Support MThreads (MUSA) GPU #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Summary of ChangesHello @yeahdongcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for Moore Threads (MUSA) GPUs into LightLLM, broadening the framework's hardware ecosystem. The changes involve platform-specific device detection, adjustments to a core Triton kernel for MUSA compatibility, and the addition of a utility to identify MUSA's inter-GPU communication technology, setting the stage for future multi-GPU capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@helloyongyang Please take a look when you are available. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Moore Threads (MUSA) GPUs, which is a great step towards broader hardware compatibility. The changes include platform detection logic, a new utility to check for MTLink, and a kernel modification for Triton compatibility. My review focuses on improving the robustness of the new device detection logic to prevent potential runtime errors and ensure it works correctly across different system configurations.
|
Thanks for your contribution! I will review it as soon as i can. |
This PR adds support for Moore Threads (MUSA) GPU platform, expanding LightLLM's hardware compatibility.
NOTE:
_fwd_kernel_token_att1has been slightly updated to ensure compatibility with the Triton version.has_mtlinkwill be used in upcoming enhancements to enable multi-GPU support.torch/torch_musaneed to be upgraded to the latest versions.Testing Done