Skip to content

compat: add backward compatibility to support old model parameters#932

Merged
helloyongyang merged 1 commit intomainfrom
dev/seko_compat_old_model
Mar 10, 2026
Merged

compat: add backward compatibility to support old model parameters#932
helloyongyang merged 1 commit intomainfrom
dev/seko_compat_old_model

Conversation

@wangshankun
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the backward compatibility of the audio scheduler by making the infer_steps parameter handling more robust. It allows the prepare method to gracefully handle scenarios where infer_steps might not be explicitly passed, ensuring that older model configurations can continue to operate correctly by falling back to the default value defined in the model's configuration.

Highlights

  • Backward Compatibility for infer_steps: Removed the direct initialization of self.infer_steps from the __init__ method of the scheduler.
  • Flexible prepare method: Modified the prepare method to accept infer_steps as an optional parameter, ensuring that if it's not provided, the value from the configuration (self.config["infer_steps"]) is used instead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lightx2v/models/schedulers/wan/audio/scheduler.py
    • Removed the self.infer_steps attribute initialization from the __init__ method.
    • Updated the prepare method signature to make infer_steps an optional argument with a default value of None.
    • Added conditional logic within the prepare method to use the provided infer_steps or retrieve it from self.config if not explicitly passed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the EulerScheduler to allow infer_steps to be specified at runtime via the prepare method, falling back to the configuration value if not provided. This increases the flexibility of the scheduler. The changes are logical, and I have a minor suggestion to improve code conciseness.

Comment on lines +97 to +100
if infer_steps is not None:
self.infer_steps = infer_steps
else:
self.infer_steps = self.config["infer_steps"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness, you can simplify this if-else block into a single line using a conditional expression.

        self.infer_steps = infer_steps if infer_steps is not None else self.config["infer_steps"]

@helloyongyang helloyongyang merged commit 6bc7885 into main Mar 10, 2026
2 checks passed
@helloyongyang helloyongyang deleted the dev/seko_compat_old_model branch March 10, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants