Skip to content

Fix inconsistency in memory variable naming - #415

Merged
CGodiksen merged 10 commits into
mainfrom
dev/rename-to-ingested
Aug 7, 2026
Merged

Fix inconsistency in memory variable naming#415
CGodiksen merged 10 commits into
mainfrom
dev/rename-to-ingested

Conversation

@CGodiksen

Copy link
Copy Markdown
Collaborator

This PR closes #414 by fixing the inconsistent naming of the memory variable that was either multivariate or ingested. We now use ingested everywhere. We still use multivariate when talking about the shape of the data but when talking about memory we now use ingested.

The PR also adds crate descriptions to the dev docs for the two crates that were added earlier without a crate description.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves the naming inconsistency for the “reserved memory for ingested data” configuration by standardizing on ingested_* across the server CLI/configuration, Flight protocol, and user-facing docs. It also updates dev documentation to include crate descriptions for previously undocumented crates.

Changes:

  • Renamed the reserved-memory setting from multivariate_* to ingested_* across configuration handling, Flight protocol, and server update paths.
  • Updated integration/unit tests and user documentation to reflect the new setting/flag/environment variable names.
  • Added crate descriptions to the developer documentation (and a small formatting-only change in modelardb_auth).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/user/README.md Updates documented CLI flag and env var name for the ingested reserved memory setting.
docs/dev/README.md Adds missing crate descriptions for modelardb_auth and modelardb_macros.
crates/modelardb_types/src/flight/protocol.proto Renames the configuration field and update-setting enum entry to ingested_*.
crates/modelardb_server/tests/integration_test.rs Updates integration tests to use the new proto-generated field/enum names.
crates/modelardb_server/src/storage/types.rs Renames test functions to match the new “ingested” terminology.
crates/modelardb_server/src/storage/mod.rs Wires ingested_reserved_memory_in_bytes() into MemoryPool construction and renames the adjust method.
crates/modelardb_server/src/remote/mod.rs Updates the server-side UpdateConfiguration handling to the new setting name.
crates/modelardb_server/src/main.rs Renames the CLI arg/env var binding to ingested_reserved_memory_in_bytes.
crates/modelardb_server/src/configuration.rs Renames the persisted configuration field and its getters/setters to ingested_*.
crates/modelardb_auth/src/lib.rs Formatting-only change to error mapping closure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/modelardb_server/src/configuration.rs Outdated
@CGodiksen
CGodiksen requested a review from chrthomsen August 7, 2026 11:37
Comment thread crates/modelardb_server/src/configuration.rs Outdated
Comment thread crates/modelardb_server/src/main.rs Outdated
Comment thread crates/modelardb_types/src/flight/protocol.proto Outdated
Comment thread docs/user/README.md Outdated
@CGodiksen
CGodiksen merged commit cc31848 into main Aug 7, 2026
5 checks passed
@CGodiksen
CGodiksen deleted the dev/rename-to-ingested branch August 7, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inconsistency in memory variable naming

4 participants