Use modelardb_embedded Client in CLI - #421
Merged
Merged
Conversation
…reated or dropped
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the modelardb_client CLI to use the modelardb_embedded Client (instead of a bespoke Arrow Flight client) to unify server access patterns across the codebase, while also extending the CLI/REPL with additional commands and updating KillNode semantics and docs.
Changes:
- Replace the CLI’s manual Arrow Flight client plumbing with
modelardb_embedded::operations::client::Clientand update dependencies accordingly. - Extend the REPL with commands for configuration, cluster/node introspection, and configuration updates; refresh tab-completions after CREATE/DROP.
- Update
KillNodebehavior and documentation to no longer transfer to the remote object store (flush-to-disk only), aligning CLI/server semantics.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/user/README.md | Updates REPL command documentation and adds newly supported commands. |
| crates/modelardb_server/src/remote/mod.rs | Changes KillNode to flush-to-disk only (no remote transfer) and updates action docs/descriptions. |
| crates/modelardb_embedded/src/operations/client.rs | Updates Client::kill_node documentation to reflect the new semantics. |
| crates/modelardb_client/src/main.rs | Refactors CLI to use embedded Client, adds new REPL commands, and adjusts batch printing/confirmation logic. |
| crates/modelardb_client/src/error.rs | Replaces Tonic-specific error variants with a ModelarDbEmbeddedError wrapper. |
| crates/modelardb_client/Cargo.toml | Drops Arrow Flight/Tonic/auth deps and adds modelardb_embedded, modelardb_types, and futures. |
| Cargo.lock | Updates lockfile to match dependency refactor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
skejserjensen
approved these changes
Aug 18, 2026
chrthomsen
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #417 by refactoring the CLI in
modelardb_clientto useClientfrommodelardb_embeddedinstead of a separate manual Apache Arrow Flight client. This unifies the way we access the server in the system and removes unnecessary code in the CLI. Other than refactoring the existing functionality, new commands have also been added to the CLI so it supports all the relevant methods that we expose through theClientAPI.The PR also changes tab completion slightly so we now update the possible completions when we create or drop tables, and it updates the
KillNodeaction to make it consistent with how we handlectrl+cin the server. We now no longer try to transfer data when killing a node, and now only flush to disk. If a user wants to flush to the remote object store before killing a node, they can callFlushNodeseparately.