Skip to content

Use Rust 1.97.1 to compile on Windows - #426

Merged
skejserjensen merged 4 commits into
mainfrom
bug/lock-rust-version
Aug 25, 2026
Merged

Use Rust 1.97.1 to compile on Windows#426
skejserjensen merged 4 commits into
mainfrom
bug/lock-rust-version

Conversation

@skejserjensen

@skejserjensen skejserjensen commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This PR specifies a specific Rust version to use to avoid Rust 1.98.0, as it segfaults on Microsoft Windows when running our tests. @CGodiksen verified that it also happens with main and not just #424 and #425, so it seems to be a problem with Rust 1.98.0. I have not verified what causes this segfault, but it may be this issue rust-lang/rust#161441 as it was introduced in Rust 1.98.0 and should be a near guaranteed segfault according to the comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR pins the repository to Rust 1.97.1 to avoid test segfaults observed on Microsoft Windows with Rust 1.98.0, and updates user documentation accordingly.

Changes:

  • Added rust-toolchain.toml to pin the toolchain to Rust 1.97.1 (with a minimal profile and clippy).
  • Updated the user installation guide to reference Rust 1.97.1 instead of “latest stable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
rust-toolchain.toml Pins the repo’s Rust toolchain to 1.97.1 to avoid Windows segfaults on 1.98.0.
docs/user/README.md Updates installation instructions to reflect the pinned Rust version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/user/README.md Outdated
Comment thread docs/user/README.md Outdated
Comment thread rust-toolchain.toml Outdated
Comment thread .github/workflows/build-lint-test-and-upload.yml Outdated
Comment thread .github/workflows/build-lint-test-and-upload.yml Outdated
@workingjubilee

workingjubilee commented Aug 24, 2026

Copy link
Copy Markdown

You can use https://github.com/rust-lang/cargo-bisect-rustc to attempt to identify the nightly that caused the issue. It does not require detailed knowledge of what is going wrong, only a test script that can reproduce the issue.

@skejserjensen
skejserjensen force-pushed the bug/lock-rust-version branch from a590ce9 to 3ede9e0 Compare August 25, 2026 08:07
@skejserjensen

Copy link
Copy Markdown
Contributor Author

You can use https://github.com/rust-lang/cargo-bisect-rustc to attempt to identify the nightly that caused the issue. It does not require detailed knowledge of what is going wrong, only a test script that can reproduce the issue.

Thank you for the information. I will try to set up a machine with Microsoft Windows and try running our tests with the nightlies between Rust 1.97.1 and Rust 1.98.0 to determine when it starts failing.

@skejserjensen
skejserjensen merged commit 5d22bde into main Aug 25, 2026
5 checks passed
@skejserjensen
skejserjensen deleted the bug/lock-rust-version branch August 25, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants