Use Rust 1.97.1 to compile on Windows - #426
Conversation
There was a problem hiding this comment.
Pull request overview
This PR pins the repository to Rust 1.97.1 to avoid test segfaults observed on Microsoft Windows with Rust 1.98.0, and updates user documentation accordingly.
Changes:
- Added
rust-toolchain.tomlto pin the toolchain to Rust 1.97.1 (with a minimal profile and clippy). - Updated the user installation guide to reference Rust 1.97.1 instead of “latest stable”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust-toolchain.toml | Pins the repo’s Rust toolchain to 1.97.1 to avoid Windows segfaults on 1.98.0. |
| docs/user/README.md | Updates installation instructions to reflect the pinned Rust version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
You can use https://github.com/rust-lang/cargo-bisect-rustc to attempt to identify the nightly that caused the issue. It does not require detailed knowledge of what is going wrong, only a test script that can reproduce the issue. |
a590ce9 to
3ede9e0
Compare
Thank you for the information. I will try to set up a machine with Microsoft Windows and try running our tests with the nightlies between Rust 1.97.1 and Rust 1.98.0 to determine when it starts failing. |
This PR specifies a specific Rust version to use to avoid Rust 1.98.0, as it segfaults on Microsoft Windows when running our tests. @CGodiksen verified that it also happens with
mainand not just #424 and #425, so it seems to be a problem with Rust 1.98.0. I have not verified what causes this segfault, but it may be this issue rust-lang/rust#161441 as it was introduced in Rust 1.98.0 and should be a near guaranteed segfault according to the comments.