Add support for testing vacuum in Apache Arrow Flight Tester - #51
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for testing vacuum functionality in the Apache Arrow Flight Tester by introducing a new vacuum() method and updating protocol buffers to include retention period configuration.
- Adds a new
vacuum()method to the common client interface for testing vacuum operations - Updates protocol buffers to include
retention_period_in_secondsconfiguration field - Fixes a minor capitalization issue in a comment
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Apache-Arrow-Flight-Tester/common.py | Adds vacuum() method to support testing vacuum operations on tables |
| Apache-Arrow-Flight-Tester/protobuf/protocol.proto | Adds retention_period_in_seconds field and updates field numbers for thread configurations |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py | Auto-generated Python protobuf file reflecting the protocol changes |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi | Auto-generated Python type stubs reflecting the protocol changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
skejserjensen
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method and updates the protocol buffers so
VACUUMcan be tested.Note that this PR should not be merged before ModelarData/ModelarDB-RS#344 is merged.