Add new actions to Apache Arrow Flight Tester - #60
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Apache Arrow Flight tester client to exercise additional ModelarDB Flight actions and updates the bundled protobuf protocol and Python dependencies to match the newer upstream definitions.
Changes:
- Add Flight client helpers for the
ListNodesandNodeMetricsactions. - Update Python dependency pins (including explicitly pinning
protobuf). - Update the protobuf schema and regenerated Python protobuf artifacts to the latest upstream.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Apache-Arrow-Flight-Tester/server.py | Adds list_nodes() and node_metrics() helpers that call Flight actions and parse protobuf responses. |
| Apache-Arrow-Flight-Tester/requirements.txt | Updates dependency versions and adds a pinned protobuf runtime version. |
| Apache-Arrow-Flight-Tester/protobuf/protocol.proto | Updates the protocol schema (config changes + new cluster/node messages). |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi | Regenerated typing stubs for the updated protocol. |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py | Regenerated Python protobuf code for the updated protocol. |
Files not reviewed (1)
- Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
skejserjensen
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for testing the
ListNodesandNodeMetricsactions through the Apache Arrow Flight tester. It also updates the requirements to the newest version, pins the version of protobuf to fix a protoc issue, and updates the.protofile to the newest version from ModelarDB-RS.